You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/16 04:29:13 UTC

[GitHub] [iotdb] bigreybear opened a new pull request #5252: Enhance check statement before writing mlog

bigreybear opened a new pull request #5252:
URL: https://github.com/apache/iotdb/pull/5252


   Reason of the ISSUE:
   
   During recovery from mlog.bin, MManager::MLogWrite is not initialized since there is no need to write a new entry into mlog, which directly causes the NPE of this issue. This may be caused by nonstandard usage of Templates or originate from disharmonious implementation between MManager and TemplateManager. We will make a thorough refactor to these modules soon.
   
   To fix this issue, we enhanced the check statement before writing entry into mlog.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls commented on pull request #5252: [To rel/0.13][IOTDB-2750] Enhance check statement before writing mlog

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5252:
URL: https://github.com/apache/iotdb/pull/5252#issuecomment-1068753165


   
   [![Coverage Status](https://coveralls.io/builds/47405394/badge)](https://coveralls.io/builds/47405394)
   
   Coverage increased (+0.03%) to 67.921% when pulling **1e086217375c6fff3afa06ab9b6ab663eca4afbc on bigreybear:i2570** into **b0d0af35125856a0b22fd2df4b876cb540558274 on apache:rel/0.13**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] qiaojialin merged pull request #5252: [To rel/0.13][IOTDB-2750] Enhance check statement before writing mlog

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5252:
URL: https://github.com/apache/iotdb/pull/5252


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org