[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #947: [IOTDB-560] add TsFileInputFormat for reading TsFiles on flink.

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #947: [IOTDB-560] add TsFileInputFormat for reading TsFiles on flink.
URL: https://github.com/apache/incubator-iotdb/pull/947#discussion_r399787181
 
 

 ##########
 File path: flink-tsfile/src/main/java/org/apache/iotdb/flink/tsfile/util/TSFileConfigUtil.java
 ##########
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.flink.tsfile.util;
+
+import org.apache.iotdb.tsfile.common.conf.TSFileConfig;
+import org.apache.iotdb.tsfile.common.conf.TSFileDescriptor;
+
+/**
+ * Utils of setting global TSFileConfig.
+ */
+public class TSFileConfigUtil {
+	
+	public static void setGlobalTSFileConfig(TSFileConfig config) {
+		TSFileConfig globalConfig = TSFileDescriptor.getInstance().getConfig();
 
 Review comment:
   Hi, this may be hard to maintain... how about let the user directly use TSFileConfig as follows if they want to change some configuration:
   
   TSFileConfig config = TsFileDescriptor.getInstance().getConfig();
   config.setXXX();

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services