You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2015/05/21 19:48:43 UTC
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/581
TAJO-1618 [Rest API] queries/{queryId} should set default print type
currently REST API /queries/
{queryId} cause error without print parameter.
and submit query just return url of /queries/{queryId}
without print type.
so I think it is better to set default print type when users don't pass print querystring.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo feature/rest-default-printtype
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/581.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #581
----
commit 033bfb61a342517d5d8d4c22e745e3467d13b586
Author: clark.kang <cl...@kakao.com>
Date: 2015-05-21T17:17:49Z
set default queryinfo printtype
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/581#issuecomment-105886476
@jihoonson I will update it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/581#issuecomment-105878127
+1. Thanks @charsyam. It works well. I'll change indent before commit.
Anyway, this patch requires to update our document for REST API (https://cwiki.apache.org/confluence/display/TAJO/TAJO+REST+API). Would you update it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/581#issuecomment-105262952
@jihoonson I attached patch on jira.
and it passed. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/581#issuecomment-105237171
It seems that there were some problems to download some maven jars.
Would you trigger the test again?
It would be nice if you trigger the jenkins test by putting your patch on jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/581
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1618 [Rest API] queries/{queryId} should s...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/581#issuecomment-105886663
@jihoonson and I'm sorry for indent. Actually I fixed it , but I forgot push. sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---