You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2018/08/24 18:03:16 UTC

[GitHub] spark pull request #22225: [SPARK-25234][SPARKR] avoid integer overflow in p...

GitHub user mengxr opened a pull request:

    https://github.com/apache/spark/pull/22225

    [SPARK-25234][SPARKR] avoid integer overflow in parallelize

    ## What changes were proposed in this pull request?
    
    `parallelize` uses integer multiplication to determine the split indices. It might cause integer overflow.
    
    ## How was this patch tested?
    
    unit test
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mengxr/spark SPARK-25234

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22225
    
----
commit 20f9498384ef5587970c3673c86488404ee89a54
Author: Xiangrui Meng <me...@...>
Date:   2018-08-24T18:01:14Z

    add test

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [WIP][SPARK-25234][SPARKR] avoid integer overflow in par...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95222/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [WIP][SPARK-25234][SPARKR] avoid integer overflow in par...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2537/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [WIP][SPARK-25234][SPARKR] avoid integer overflow in par...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    **[Test build #95222 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95222/testReport)** for PR 22225 at commit [`20f9498`](https://github.com/apache/spark/commit/20f9498384ef5587970c3673c86488404ee89a54).
     * This patch **fails SparkR unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [SPARK-25234][SPARKR] avoid integer overflow in parallel...

Posted by mengxr <gi...@git.apache.org>.

Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Merged into master and branch-2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [SPARK-25234][SPARKR] avoid integer overflow in parallel...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    **[Test build #95228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95228/testReport)** for PR 22225 at commit [`19ad5c3`](https://github.com/apache/spark/commit/19ad5c310fe36e75564715ae65fc1a13d808a09f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [WIP][SPARK-25234][SPARKR] avoid integer overflow in par...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [WIP][SPARK-25234][SPARKR] avoid integer overflow in par...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [SPARK-25234][SPARKR] avoid integer overflow in parallel...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    **[Test build #95228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95228/testReport)** for PR 22225 at commit [`19ad5c3`](https://github.com/apache/spark/commit/19ad5c310fe36e75564715ae65fc1a13d808a09f).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [SPARK-25234][SPARKR] avoid integer overflow in parallel...

Posted by mengxr <gi...@git.apache.org>.

Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    cc @falaki 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [SPARK-25234][SPARKR] avoid integer overflow in parallel...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95228/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22225: [SPARK-25234][SPARKR] avoid integer overflow in parallel...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22225
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org