[GitHub] [arrow] eitsupi commented on a diff in pull request #13690: ARROW-17088: [R] Use `.arrow` as extension of IPC files of datasets

[GitBox <gi...@apache.org>]

eitsupi commented on code in PR #13690:
URL: https://github.com/apache/arrow/pull/13690#discussion_r933791974


##########
r/R/dataset-write.R:
##########
@@ -34,8 +34,9 @@
 #' use the current `group_by()` columns.
 #' @param basename_template string template for the names of files to be written.
 #' Must contain `"{i}"`, which will be replaced with an autoincremented
-#' integer to generate basenames of datafiles. For example, `"part-{i}.feather"`
-#' will yield `"part-0.feather", ...`.
+#' integer to generate basenames of datafiles. For example, `"part-{i}.arrow"`
+#' will yield `"part-0.arrow", ...`.
+#' If not specified, it defaults to "part-{i}." + format.

Review Comment:
   ```suggestion
   #' If not specified, it defaults to "part-{i}.<default extension>".
   ```



##########
r/tests/testthat/test-dataset-write.R:
##########
@@ -469,9 +501,6 @@ test_that("Dataset writing: unsupported features/input validation", {
   expect_error(
     write_dataset(ds, tempfile(), basename_template = "something_without_i")
   )
-  expect_error(
-    write_dataset(ds, tempfile(), basename_template = NULL)
-  )

Review Comment:
   I think these lines should not be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org