[jira] [Commented] (AMBARI-22426) Push down Logger instances

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-22426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250164#comment-16250164 ] 

Hadoop QA commented on AMBARI-22426:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12897324/AMBARI-22426.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 core tests{color}.  The test build failed in [ambari-server|https://builds.apache.org/job/Ambari-trunk-test-patch/12660//artifact/patch-work/testrun_ambari-server.txt] 

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12660//console

This message is automatically generated.

> Push down Logger instances
> --------------------------
>
>                 Key: AMBARI-22426
>                 URL: https://issues.apache.org/jira/browse/AMBARI-22426
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 3.0.0
>            Reporter: Doroszlai, Attila
>            Assignee: Doroszlai, Attila
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: AMBARI-22426.patch
>
>
> {{Logger}} prepends classname and line number to log messages.  Reusing {{Logger}} from other classes makes it more difficult to understand where the log message is coming from.  This includes {{Logger}} instances inherited from parent classes.
> {noformat:title=example}
> 13 Nov 2017 11:55:13,571  INFO [ambari-client-thread-36] AbstractResourceProvider:525 - Creating Cluster 'TEST' based on blueprint 'blue'.
> 13 Nov 2017 11:55:13,623 ERROR [ambari-client-thread-36] BaseManagementHandler:79 - Caught a runtime exception while attempting to create a resource: null
> {noformat}
> In the above example, log is written from {{ClusterResourceProvider}} and {{CreateHandler}}, respectively, but one needs to search the source code for the messages to find this out.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)