You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/05/26 11:31:09 UTC
[Impala-CR](cdh5-trunk) IMPALA-2550: Clean up RPC structures in ImpalaInternalService
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3202
Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
......................................................................
IMPALA-2550: Clean up RPC structures in ImpalaInternalService
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 188 insertions(+), 180 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/02/3202/6
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-CR](cdh5-trunk) Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3202
to look at the new patch set (#8).
Change subject: Clean up RPC structures in ImpalaInternalService
......................................................................
Clean up RPC structures in ImpalaInternalService
This change is a pre-requisite for IMPALA-2550.
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 192 insertions(+), 182 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/02/3202/8
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 11: Code-Review+2
Rebased, +2 from Marcel
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 9: Code-Review+2
Rebased, added Jira# to commit message. +2 from Marcel.
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3202
to look at the new patch set (#9).
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
IMPALA-3627: Clean up RPC structures in ImpalaInternalService
This change is a pre-requisite for IMPALA-2550.
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 192 insertions(+), 182 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/02/3202/9
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) Clean up RPC structures in ImpalaInternalService
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 7:
let's check this into trunk, there's no need for it to be included in 2.6.
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-2550: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 6:
Should we target this for cdh5-trunk? Or 2.6.0?
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-2550: Clean up RPC structures in ImpalaInternalService
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3202/6//COMMIT_MSG
Commit Message:
Line 7: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
This doesn't solve IMPALA-2550 right, it's just cleanup on the way to that? Can you make that clearer in the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 7:
Will do. I managed to push an empty PS7, please see PS8 for the latest (small) additions.
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-2550: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 4:
(6 comments)
Thanks for the review. Please see PS 6.
http://gerrit.cloudera.org:8080/#/c/3202/4/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:
Line 1379: fragment_instance_states_[global_fragment_instance_idx] = exec_state;
> here it is used locally as an index into fragment_instance_states_ (so mayb
Done
Line 1513: uint32_t global_fragment_instance_idx = params.global_fragment_instance_idx;
> here it's also indexing into fragment_instance_states_.
Done
http://gerrit.cloudera.org:8080/#/c/3202/4/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:
Line 1090: << " fragment instance#=" << params.global_fragment_instance_idx
> i don't see this being used (read) anywhere other than here and in the erro
Done
http://gerrit.cloudera.org:8080/#/c/3202/4/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:
Line 319: // Parameters for a single execution instance of a particular TPlanFragment
> remove; now superseded
Done
Line 320: // Context of a fragment instance, including its unique id, the total number
> how about "execution parameters of a ..."
Done
Line 331: // Index of this fragment instance across all combined instances in this query.
> it looks like this specifically indexes into Coordinator::fragment_instance
Done
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-2550: Clean up RPC structures in ImpalaInternalService
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 6: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3202/6/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:
Line 428: /// 'instance_state_idx' is the 0-based query-wide ordinal of the fragment instance.
fix comment: mention fragment_instance_states_ explicitly
http://gerrit.cloudera.org:8080/#/c/3202/6/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:
Line 330: // Index of this fragment instance across all combined instances in this query, used to
i would really just say that this is the instance's index into Coordinator::fragment_instance_states_. outside of that it doesn't have any meaning.
Line 456: // required in V1
add comment (refer back to TPlanFragmentInstanceCtx.instance_state_idx; that makes it clear where this comes from)
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3202
to look at the new patch set (#7).
Change subject: Clean up RPC structures in ImpalaInternalService
......................................................................
Clean up RPC structures in ImpalaInternalService
This change is a pre-requisite for IMPALA-2550.
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 188 insertions(+), 180 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/02/3202/7
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3202
to look at the new patch set (#10).
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
IMPALA-3627: Clean up RPC structures in ImpalaInternalService
This change is a pre-requisite for IMPALA-2550.
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 193 insertions(+), 180 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/02/3202/10
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
IMPALA-3627: Clean up RPC structures in ImpalaInternalService
This change is a pre-requisite for IMPALA-2550.
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
Reviewed-on: http://gerrit.cloudera.org:8080/3202
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 193 insertions(+), 180 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 12
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 6:
(4 comments)
Thanks for the comments, please see PS7
http://gerrit.cloudera.org:8080/#/c/3202/6//COMMIT_MSG
Commit Message:
Line 7: IMPALA-2550: Clean up RPC structures in ImpalaInternalService
> This doesn't solve IMPALA-2550 right, it's just cleanup on the way to that?
Done
http://gerrit.cloudera.org:8080/#/c/3202/6/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:
Line 428: /// 'instance_state_idx' is the 0-based query-wide ordinal of the fragment instance.
> fix comment: mention fragment_instance_states_ explicitly
Done
http://gerrit.cloudera.org:8080/#/c/3202/6/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:
Line 330: // Index of this fragment instance across all combined instances in this query, used to
> i would really just say that this is the instance's index into Coordinator:
Done
Line 456: // required in V1
> add comment (refer back to TPlanFragmentInstanceCtx.instance_state_idx; tha
Done
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
Patch Set 10: Code-Review+2
Fix for FE test failures, +2 from Marcel.
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 10
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3627: Clean up RPC structures in ImpalaInternalService
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3202
to look at the new patch set (#11).
Change subject: IMPALA-3627: Clean up RPC structures in ImpalaInternalService
......................................................................
IMPALA-3627: Clean up RPC structures in ImpalaInternalService
This change is a pre-requisite for IMPALA-2550.
Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
TODO: Write commit message
---
M be/src/exec/data-sink.cc
M be/src/exec/data-sink.h
M be/src/exec/union-node.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/runtime/test-env.cc
M be/src/scheduling/query-schedule.h
M be/src/service/fragment-exec-state.cc
M be/src/service/fragment-exec-state.h
M be/src/service/fragment-mgr.cc
M be/src/service/impala-server.cc
M common/thrift/ImpalaInternalService.thrift
M common/thrift/PlanNodes.thrift
17 files changed, 193 insertions(+), 180 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/02/3202/11
--
To view, visit http://gerrit.cloudera.org:8080/3202
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad
Gerrit-PatchSet: 11
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>