You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/07/20 17:37:36 UTC
[GitHub] [incubator-doris] TobKed opened a new pull request #6279: [Community] Fix PR labeling github action workflow
TobKed opened a new pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] TobKed commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-1019228207
Hi @tzssangglass , I am happy to help you.
If undestrand you question correctly, there is no need for any additional configuration.
GITHUB_TOKEN permissions are set here: https://github.com/apache/incubator-doris/blob/c2520c878c3d827e27c32f1dab5e5953a25b52e7/.github/workflows/approve-label.yml#L24
I am pretty sure if you introduce to APISIX same changes as in in this PR it should work out of the box.
If you need any help with it or some problems occurs do not hesitate to contact me.
**Edit**: I've checked https://github.com/apache/apisix/pull/6136 and I think the problem which you relates to there is solved here as well: important thing here is that labelling consists of two workflows:
- https://github.com/apache/incubator-doris/blob/master/.github/workflows/approve-label-trigger.yml
- https://github.com/apache/incubator-doris/blob/master/.github/workflows/approve-label.yml
where first one just triggers second one. Reason for that is described here: [Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/). In your case you may need to adjust permissions (https://github.com/apache/incubator-doris/blob/c2520c878c3d827e27c32f1dab5e5953a25b52e7/.github/workflows/approve-label.yml#L24). This article may be helpful: [Permissions for the GITHUB_TOKEN](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] tzssangglass commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-1019240779
many thanks @TobKed , I will try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] TobKed commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-884317729
I have updated description. Ready for review.
cc @morningman @EmmyMiao87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-886210803
Thanks @TobKed , it works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] tzssangglass commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-1017371370
hi @TobKed, I am a developer from the Apache APISIX community and I have a similar question.
Sorry for taking your time, I would like to ask a question, do I need to give GITHUB_TOKEN write permission to post comments elsewhere in Github Action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-883841168
> I will add description and then ping for reviews.
Great, thank you very much for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] TobKed commented on pull request #6279: [Community] Fix PR labeling github action workflow
Posted by GitBox <gi...@apache.org>.
TobKed commented on pull request #6279:
URL: https://github.com/apache/incubator-doris/pull/6279#issuecomment-883576821
I will add description and then ping for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org