You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "Atrament666 (via GitHub)" <gi...@apache.org> on 2023/07/14 22:03:15 UTC

[GitHub] [netbeans] Atrament666 opened a new issue, #6199: Rerun failed tests button is not getting enabled

Atrament666 opened a new issue, #6199:
URL: https://github.com/apache/netbeans/issues/6199

   ### Apache NetBeans version
   
   Apache NetBeans 18
   
   ### What happened
   
   I have noticed that when running unit tests, the button for reruning failed tests in Test Results never gets enabled. 
   
   ### How to reproduce
   
   * Create Java with Maven project
   * Add some unit tests that fail
   * Run tests and check the button - should be enabled but it's not.
   
   ### Did this work correctly in an earlier version?
   
   No / Don't know
   
   ### Operating System
   
   Manjaro Linux
   
   ### JDK
   
   OpenJDK 11
   
   ### Apache NetBeans packaging
   
   Apache NetBeans binary zip
   
   ### Anything else
   
   I checked the source code and the problem seems to be in the condition
   `rerunFailedButton.setEnabled(displayHandler.sessionFinished && 
                                        rerunHandler.enabled(RerunType.CUSTOM) &&
                                        !treePanel.getFailedTests().isEmpty());`
   in netbeans/ide/gsf.testrunner.ui/src/org/netbeans/modules/gsf/testrunner/ui/StatisticsPanel.java
   
   RerunType.CUSTOM doesn't seem to be used anywhere thus the condition is always false. Using `RerunType.ALL` fixes the issue, but I am not sure if it has any side-effects, I haven't found any yet.
   
   ### Are you willing to submit a pull request?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on issue #6199: Rerun failed tests button is not getting enabled

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on issue #6199:
URL: https://github.com/apache/netbeans/issues/6199#issuecomment-1637113619

   Same behavior on master (02dafb29b878e45d66be1e1dc95f018f8e71cf87)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] asbachb commented on issue #6199: Rerun failed tests button is not getting enabled

Posted by "asbachb (via GitHub)" <gi...@apache.org>.
asbachb commented on issue #6199:
URL: https://github.com/apache/netbeans/issues/6199#issuecomment-1636989480

   Could reproduce this on NetBean 18, OpenJDK17, Maven Project:
   
   Create Maven Project, Tools -> Create / Update Tests, `assertTrue(false);`, Right Click Test class -> Test File
   
   Rerun failed button cannot be clicked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net closed issue #6199: Rerun failed tests button is not getting enabled

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net closed issue #6199: Rerun failed tests button is not getting enabled
URL: https://github.com/apache/netbeans/issues/6199


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists