You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by ma...@apache.org on 2011/12/08 23:30:28 UTC
svn commit: r1212173 - in /zookeeper/branches/branch-3.4: CHANGES.txt
src/c/src/zookeeper.c
Author: mahadev
Date: Thu Dec 8 22:30:28 2011
New Revision: 1212173
URL: http://svn.apache.org/viewvc?rev=1212173&view=rev
Log:
ZOOKEEPER-1316. zookeeper_init leaks memory if chroot is just '/'. (Akira Kitada via mahadev)
Modified:
zookeeper/branches/branch-3.4/CHANGES.txt
zookeeper/branches/branch-3.4/src/c/src/zookeeper.c
Modified: zookeeper/branches/branch-3.4/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.4/CHANGES.txt?rev=1212173&r1=1212172&r2=1212173&view=diff
==============================================================================
--- zookeeper/branches/branch-3.4/CHANGES.txt (original)
+++ zookeeper/branches/branch-3.4/CHANGES.txt Thu Dec 8 22:30:28 2011
@@ -9,6 +9,9 @@ BUGFIXES:
ZOOKEEPER-1305. zookeeper.c:prepend_string func can dereference null ptr.
(Daniel Lescohier via mahadev)
+ ZOOKEEPER-1316. zookeeper_init leaks memory if chroot is just '/'.
+ (Akira Kitada via mahadev)
+
Release 3.4.0 - 2011-10-25
Non-backward compatible changes:
Modified: zookeeper/branches/branch-3.4/src/c/src/zookeeper.c
URL: http://svn.apache.org/viewvc/zookeeper/branches/branch-3.4/src/c/src/zookeeper.c?rev=1212173&r1=1212172&r2=1212173&view=diff
==============================================================================
--- zookeeper/branches/branch-3.4/src/c/src/zookeeper.c (original)
+++ zookeeper/branches/branch-3.4/src/c/src/zookeeper.c Thu Dec 8 22:30:28 2011
@@ -804,6 +804,7 @@ zhandle_t *zookeeper_init(const char *ho
zh->chroot = strdup(index_chroot);
// if chroot is just / set it to null
if (strlen(zh->chroot) == 1) {
+ free(zh->chroot);
zh->chroot = NULL;
}
// cannot use strndup so allocate and strcpy