[GitHub] [solr] patsonluk commented on a diff in pull request #1143: SOLR-16506 : Throws exception on core startup for node name mismatch

[GitBox <gi...@apache.org>]

patsonluk commented on code in PR #1143:
URL: https://github.com/apache/solr/pull/1143#discussion_r1007601857


##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -2899,6 +2920,23 @@ public NotInClusterStateException(ErrorCode code, String msg) {
     }
   }
 
+  /**
+   * Thrown during pre-register process if the replica is found in clusterstate but is inconsistent
+   * with current node name
+   */
+  public static class InconsistentClusterStateException extends SolrException {

Review Comment:
   The new exception better identifies a new type of exception. This cannot be `NotInClusterStateException`, otherwise the `CoreContainer` will attempt to unload (ie delete)  the core at https://github.com/fullstorydev/lucene-solr/blob/release/8.8/solr/core/src/java/org/apache/solr/core/CoreContainer.java#L1525.
   
   The extra field is just to store the info which could be useful for any future handling/logging



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org