You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/13 18:04:03 UTC

[GitHub] [thrift] varunsh-coder opened a new pull request, #2664: add minimum GitHub token permissions for workflows

varunsh-coder opened a new pull request, #2664:
URL: https://github.com/apache/thrift/pull/2664

   ### Description
   This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using https://github.com/step-security/secure-workflows. 
   
   GitHub Actions workflows have a GITHUB_TOKEN with `write` access to multiple scopes. 
   Here is an example of the permissions in one of the workflows:
   https://github.com/apache/thrift/actions/runs/3045440603/jobs/4907003617#step:1:19
   
   After this change, the scopes will be reduced to the minimum needed for each workflow. 
   
   ### Motivation and Context
   
   - This is a security best practice, so if the GITHUB_TOKEN is compromised due to a vulnerability or compromised Action, the damage will be reduced. 
   - GitHub recommends defining minimum GITHUB_TOKEN permissions. 
   https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
   - The Open Source Security Foundation (OpenSSF) [Scorecards](https://github.com/ossf/scorecard) also treats not setting token permissions as a high-risk issue. This change will help increase the Scorecard score for this repository. 
   
   Signed-off-by: Varun Sharma <va...@stepsecurity.io>
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist merged pull request #2664: add minimum GitHub token permissions for workflows

Posted by GitBox <gi...@apache.org>.
Jimexist merged PR #2664:
URL: https://github.com/apache/thrift/pull/2664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2664: add minimum GitHub token permissions for workflows

Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2664:
URL: https://github.com/apache/thrift/pull/2664#issuecomment-1245899820

   +1 LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org