[GitHub] mistercrunch commented on issue #5174: Gantt Chart visualization

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #5174: Gantt Chart visualization
URL: https://github.com/apache/incubator-superset/pull/5174#issuecomment-396837090
 
 
   I pulled the branch and reloaded the examples, but the example chart failed to load properly. Looks like control name mismatch between the example and the actual new controls. After finding the `tasks` table and picking the right fields and colors it started looking good.
   
   I also like the new `StyleMappingControl`, I can see reusing this in other places. 
   
   Few usability recommendations before I get into the code:
   * we should use a palette and attribute colors to statuses for the ones that user have not provided a color mapping yet (checkout function `getColorFromScheme`)
   * the status should be in the tooltip
   * there's an epoch-looking number in the tooltip, let's remove it or use something more human readable
   * hovering the boxes drop the border
   * visually things look different than the nvd3, anything that would make it look more align would be best, maybe reusing some of the nvd3 css classes in the axis svg?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org