You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/03/22 03:51:56 UTC
Review Request 57827: The user group would be duplicate created if
the user group existed during installing Ranger Policy Admin.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57827/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1469
https://issues.apache.org/jira/browse/RANGER-1469
Repository: ranger
Description
-------
The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.
Diffs
-----
security-admin/scripts/setup.sh bc94874
Diff: https://reviews.apache.org/r/57827/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 57827: The user group would be duplicate created
if the user group existed during installing Ranger Policy Admin.
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On March 22, 2017, 11:35 a.m., Colm O hEigeartaigh wrote:
> > Looks fine, but change the comment from "create group if not exists" to "create group if it does not exist".
Ok. You are right. I modified and updated the patch. Thanks.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57827/#review169689
-----------------------------------------------------------
On March 22, 2017, 12:24 p.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57827/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 12:24 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1469
> https://issues.apache.org/jira/browse/RANGER-1469
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.
>
>
> Diffs
> -----
>
> security-admin/scripts/setup.sh bc94874
>
>
> Diff: https://reviews.apache.org/r/57827/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57827: The user group would be duplicate created
if the user group existed during installing Ranger Policy Admin.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57827/#review169689
-----------------------------------------------------------
Looks fine, but change the comment from "create group if not exists" to "create group if it does not exist".
- Colm O hEigeartaigh
On March 22, 2017, 3:51 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57827/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 3:51 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1469
> https://issues.apache.org/jira/browse/RANGER-1469
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.
>
>
> Diffs
> -----
>
> security-admin/scripts/setup.sh bc94874
>
>
> Diff: https://reviews.apache.org/r/57827/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57827: The user group would be duplicate created
if the user group existed during installing Ranger Policy Admin.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57827/#review169715
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 22, 2017, 12:24 p.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57827/
> -----------------------------------------------------------
>
> (Updated March 22, 2017, 12:24 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1469
> https://issues.apache.org/jira/browse/RANGER-1469
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.
>
>
> Diffs
> -----
>
> security-admin/scripts/setup.sh bc94874
>
>
> Diff: https://reviews.apache.org/r/57827/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57827: The user group would be duplicate created
if the user group existed during installing Ranger Policy Admin.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57827/
-----------------------------------------------------------
(Updated March 22, 2017, 12:24 p.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1469
https://issues.apache.org/jira/browse/RANGER-1469
Repository: ranger
Description
-------
The user group would be duplicate created if the user group existed during installing Ranger Policy Admin.
Diffs (updated)
-----
security-admin/scripts/setup.sh bc94874
Diff: https://reviews.apache.org/r/57827/diff/2/
Changes: https://reviews.apache.org/r/57827/diff/1-2/
Testing
-------
Thanks,
Qiang Zhang