[GitHub] betodealmeida commented on a change in pull request #6829: Fix line chart overflowing the right side

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #6829: Fix line chart overflowing the right side
URL: https://github.com/apache/incubator-superset/pull/6829#discussion_r254795122
 
 

 ##########
 File path: superset/assets/src/visualizations/nvd3/NVD3Vis.js
 ##########
 @@ -641,15 +641,15 @@ function nvd3Vis(element, props) {
         // If x bounds are shown, we need a right margin
         margins.right = Math.max(20, maxXAxisLabelHeight / 2) + marginPad;
       }
-      if (staggerLabels) {
-        margins.bottom = 40;
-      } else {
+      if (xLabelRotation === 45) {
 
 Review comment:
   @kristw what was the problem with the code? I thought that since `xLabelRotation` and `staggerLabels` are mutually exclusive we could check for stagger labels first. And if no rotation is set (ie, `xLabelRotation = 0`) then lines 647-651 would have no effect since we now compute the margins based on the angle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org