You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by lewismc <gi...@git.apache.org> on 2017/04/26 01:42:33 UTC
[GitHub] climate pull request #439: CLIMATE-912 Upgrade mccSearch code from Python2 >...
GitHub user lewismc opened a pull request:
https://github.com/apache/climate/pull/439
CLIMATE-912 Upgrade mccSearch code from Python2 > 3
This issue addresses [CLIMATE-912](https://issues.apache.org/jira/browse/CLIMATE-912)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/climate CLIMATE-912
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/439.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #439
----
commit 5c86f3a87afd8c9ed136d59d3d517207efadb20a
Author: Lewis John McGibbney <le...@gmail.com>
Date: 2017-04-26T01:40:44Z
CLIMATE-912 Upgrade mccSearch code from Python2 > 3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/439
@kwhitehall if you are able to pull this PR locally and try it out with some test data (and reference the data here so I can also try it out) it would be very much appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Posted by kwhitehall <gi...@git.apache.org>.
Github user kwhitehall commented on the issue:
https://github.com/apache/climate/pull/439
Ack'ed @lewismc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #439: CLIMATE-912 Upgrade mccSearch code from Python2 >...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/climate/pull/439#discussion_r131525549
--- Diff: mccsearch/code/mainProg.py ---
@@ -55,35 +55,35 @@ def main():
# -------------------------------------------------------------------------------------------------
# let's go!
- print "\n -------------- Read MERG Data ----------"
+ print("\n -------------- Read MERG Data ----------")
mergImgs, timeList = mccSearch.readMergData(CEoriDirName)
- print ("-" * 80)
+ print(("-" * 80))
--- End diff --
Recommendation to change `print(("-" * 80))` to `print("-" * 80)` in eight places. The double nested parens `(( ))` are not needed and only slow down your reader. Repeated on lines: 60, 71, 73, 76, 78, 81, 84, 107.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Posted by kwhitehall <gi...@git.apache.org>.
Github user kwhitehall commented on the issue:
https://github.com/apache/climate/pull/439
Hey @lewismc
Tested and found the following:
1. need to convert this spaces to tabs in this folder
2. updated code to reduce the number of datasets needed to test.
Code for test can be obtained at the this [Google Drive loc](https://drive.google.com/drive/folders/0B0kFBnuqk_GTczFiU3kwWDBXaFk?usp=sharing)
Note that I did a hacky update cause another error flagged in [dataset_processor.py](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L1004-1005) by changing them to:
spatial_indices_true = np.where(spatial_values.mask.all)
spatial_indices_false = np.where(not spatial_values.mask.all)
I haven't included these as something to include in this PR as more investigation needs to be done to ensure that this doesn't break the code otherwise.
The PR has been pushed to my local [here](https://github.com/kwhitehall/climate/pull/7).
I'll work on pushing it to your PR. Do you have direction on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #439: CLIMATE-912 Upgrade mccSearch code from Python2 >...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/439
---
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/439
Hi @kwhitehall I am sorry I didn't get back to you on this.
We need to update the PR to resolve conflicts. I will take a wee look on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/439
Thank you @kwhitehall
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/climate/pull/439
Hi @kwhitehall I just went to look at some more OCW code and my local branch was set to this issue. I had to come here to remind myself what the issue was about. Did you get any time at all to take a look through this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request #439: CLIMATE-912 Upgrade mccSearch code from Python2 >...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/climate/pull/439#discussion_r131525571
--- Diff: mccsearch/code/mainProgTemplate.py ---
@@ -59,36 +59,36 @@ def main():
# -------------------------------------------------------------------------------------------------
# let's go!
- print "\n -------------- Read MERG Data ----------"
+ print("\n -------------- Read MERG Data ----------")
mergImgs, timeList = mccSearch.readMergData(CEoriDirName)
- print ("-" * 80)
+ print(("-" * 80))
--- End diff --
Recommendation to change `print(("-" * 80))` to `print("-" * 80)` in eight places. The double nested parens `(( ))` are not needed and only slow down your reader. Repeated on lines: 64, 75, 77, 80, 82, 86, 89, 112.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---