You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2013/11/18 18:57:53 UTC

Re: Review Request 15201: address Neha's review comments

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15201/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 5:57 p.m.)


Review request for kafka.


Summary (updated)
-----------------

address Neha's review comments


Bugs: KAFKA-1117
    https://issues.apache.org/jira/browse/KAFKA-1117


Repository: kafka


Description (updated)
-------

kafka-1117; fix 5


kafka-1117; fix 4


kafka-1117; fix 3


kafka-1117; fix 2


kafka-1117; fix 1


kafka-1117


Diffs (updated)
-----

  core/src/main/scala/kafka/api/OffsetResponse.scala 08dc3cd3d166efba6b2b43f6e148f636b175affe 
  core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala PRE-CREATION 

Diff: https://reviews.apache.org/r/15201/diff/


Testing
-------


Thanks,

Jun Rao

Re: Review Request 15201: address Neha's review comments

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15201/#review29067
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Nov. 18, 2013, 5:57 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15201/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 5:57 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1117
>     https://issues.apache.org/jira/browse/KAFKA-1117
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1117; fix 5
> 
> 
> kafka-1117; fix 4
> 
> 
> kafka-1117; fix 3
> 
> 
> kafka-1117; fix 2
> 
> 
> kafka-1117; fix 1
> 
> 
> kafka-1117
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/api/OffsetResponse.scala 08dc3cd3d166efba6b2b43f6e148f636b175affe 
>   core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>