You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2021/03/30 14:06:04 UTC
[GitHub] [incubator-pegasus] Smityz opened a new pull request #710: fix(hotkey): fix input and output of detect_hotkey in shell
Smityz opened a new pull request #710:
URL: https://github.com/apache/incubator-pegasus/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje merged pull request #710: fix(hotkey): fix input and output of detect_hotkey in shell
Posted by GitBox <gi...@apache.org>.
neverchanje merged pull request #710:
URL: https://github.com/apache/incubator-pegasus/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 closed pull request #710: fix(hotkey): fix input and output of detect_hotkey in shell
Posted by GitBox <gi...@apache.org>.
levy5307 closed pull request #710:
URL: https://github.com/apache/incubator-pegasus/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #710: fix(hotkey): fix input and output of detect_hotkey in shell
Posted by GitBox <gi...@apache.org>.
levy5307 commented on a change in pull request #710:
URL: https://github.com/apache/incubator-pegasus/pull/710#discussion_r604542019
##########
File path: src/shell/commands/detect_hotkey.cpp
##########
@@ -121,7 +121,28 @@ bool detect_hotkey(command_executor *e, shell_context *sc, arguments args)
partition_index,
resp.err,
resp.err_hint);
- return false;
+ return true;
+ }
+
+ switch (req.action) {
+ case dsn::replication::detect_action::START:
+ fmt::print("Detect hotkey rpc is starting, use 'detect_hotkey -a {} -p {} -t {} -c "
Review comment:
hotkey detection is starting, using ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org