You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by hi...@apache.org on 2007/08/02 15:03:38 UTC
svn commit: r562100 - in
/harmony/enhanced/drlvm/trunk/src/test/regression/H4595: Test.java
run.test.xml
Author: hindessm
Date: Thu Aug 2 06:03:37 2007
New Revision: 562100
URL: http://svn.apache.org/viewvc?view=rev&rev=562100
Log:
Fixing the commit r562098.
Correcting the svn:eol-style property which should be set automatically
if the instructions for new committers have been followed.
Adding missing licenses.
Note, the commit message was also missing the titles of the referenced
JIRA.
Modified:
harmony/enhanced/drlvm/trunk/src/test/regression/H4595/Test.java (contents, props changed)
harmony/enhanced/drlvm/trunk/src/test/regression/H4595/run.test.xml (contents, props changed)
Modified: harmony/enhanced/drlvm/trunk/src/test/regression/H4595/Test.java
URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/src/test/regression/H4595/Test.java?view=diff&rev=562100&r1=562099&r2=562100
==============================================================================
--- harmony/enhanced/drlvm/trunk/src/test/regression/H4595/Test.java (original)
+++ harmony/enhanced/drlvm/trunk/src/test/regression/H4595/Test.java Thu Aug 2 06:03:37 2007
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
package org.apache.harmony.drlvm.tests.regression.h4595;
import junit.framework.*;
Propchange: harmony/enhanced/drlvm/trunk/src/test/regression/H4595/Test.java
------------------------------------------------------------------------------
svn:eol-style = native
Modified: harmony/enhanced/drlvm/trunk/src/test/regression/H4595/run.test.xml
URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/src/test/regression/H4595/run.test.xml?view=diff&rev=562100&r1=562099&r2=562100
==============================================================================
--- harmony/enhanced/drlvm/trunk/src/test/regression/H4595/run.test.xml (original)
+++ harmony/enhanced/drlvm/trunk/src/test/regression/H4595/run.test.xml Thu Aug 2 06:03:37 2007
@@ -1,3 +1,20 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
<project name="RUN HARMONY-4514 Regression Test">
<target name="run-test">
<run-junit-test
Propchange: harmony/enhanced/drlvm/trunk/src/test/regression/H4595/run.test.xml
------------------------------------------------------------------------------
svn:eol-style = native
Re: [general] Housekeeping for committers
Posted by Mark Hindess <ma...@googlemail.com>.
On 2 August 2007 at 15:55, Tim Ellison <t....@gmail.com> wrote:
> hindessm@apache.org wrote:
> > Author: hindessm
> > Date: Thu Aug 2 06:03:37 2007
> > New Revision: 562100
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=562100
> > Log:
> > Fixing the commit r562098.
> >
> > Correcting the svn:eol-style property which should be set automatically
> > if the instructions for new committers have been followed.
> >
> > Adding missing licenses.
> >
> > Note, the commit message was also missing the titles of the referenced
> > JIRA.
>
> :-) You may get more notice on the dev list rather than in commit logs.
Seeing who noticed might be part of the experiment. ;-) (Of course, I
knew you would notice!)
Recently, Oliver kindly added the license clause(s) to some new files
I'd committed. I was feeling guilty so I decided to write a script that
checked commit messages (look for /^@@ -0,0 / and then complain if you
don't see /Licensed to the Apache/ in the next five lines) so I'd catch
it myself if I did it again.
This commit was one of the first that my script spotted so I thought I
might as well fix it.
> Please would all committers ensure they are familiar with the
> guidelines here http://wiki.apache.org/harmony/NewCommitter especially
> 'Configuring your SVN client' and 'Commit messages'.
>
> Of course, if there are guidelines things missing, or you disagree,
> you get to help fix it too!
When I next feel the overwhelming desire to hack some Perl, I'll
probably add more checks, such as;
1) svn:eol-style property checks,
2) spotting (new) tab indentation rather than spaces,
3) mentions of 'harmony-4298' instead of 'HARMONY-4298' or 'H-2742'
instead of 'HARMONY-2742', and
4) spotting missing JIRA titles - not sure how to code this reliably.
It was really just intended to catch mistakes as I make them, but
it is tempting to turn it into a filter to automatically send out
reminders to committers! ;-)
Regards,
Mark.
[general] Housekeeping for committers
Posted by Tim Ellison <t....@gmail.com>.
hindessm@apache.org wrote:
> Author: hindessm
> Date: Thu Aug 2 06:03:37 2007
> New Revision: 562100
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=562100
> Log:
> Fixing the commit r562098.
>
> Correcting the svn:eol-style property which should be set automatically
> if the instructions for new committers have been followed.
>
> Adding missing licenses.
>
> Note, the commit message was also missing the titles of the referenced
> JIRA.
:-) You may get more notice on the dev list rather than in commit logs.
Please would all committers ensure they are familiar with the guidelines
here http://wiki.apache.org/harmony/NewCommitter especially
'Configuring your SVN client' and 'Commit messages'.
Of course, if there are guidelines things missing, or you disagree, you
get to help fix it too!
Thanks,
Tim