[jira] [Work logged] (KNOX-2912) Don't fail over non idempotent requests unless it's a connect exception

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-2912?focusedWorklogId=863004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-863004 ]

ASF GitHub Bot logged work on KNOX-2912:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/23 11:14
            Start Date: 31/May/23 11:14
    Worklog Time Spent: 10m 
      Work Description: zeroflag opened a new pull request, #757:
URL: https://github.com/apache/knox/pull/757

   ## What changes were proposed in this pull request?
   
   By default Knox doesn't fail over in case of non-idempotent requests. In case of a connect exception (connection refused, unknown host, etc), it is safe to failover since the connection hasn't been established yes and the request body was not consumed.
   
   ## How was this patch tested?
   
   Testet it manually with the following config:
   
   ```
       <provider>
            <role>ha</role>
            <name>HaProvider</name>
            <enabled>true</enabled>
            <param>
               <name>HIVE</name>
               <value>enabled=true;maxFailoverAttempts=3;failoverSleep=1000</value>
            </param>
         </provider>
       </gateway>
   
       <service>
           <role>HIVE</role>
           <!

Issue Time Tracking
-------------------

            Worklog Id:     (was: 863004)
    Remaining Estimate: 0h
            Time Spent: 10m

> Don't fail over non idempotent requests unless it's a connect exception
> -----------------------------------------------------------------------
>
>                 Key: KNOX-2912
>                 URL: https://issues.apache.org/jira/browse/KNOX-2912
>             Project: Apache Knox
>          Issue Type: Task
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently knox tries to fail over non idempotent (POST/PUT/etc) requests. Failover should only happen if the request was not yet consumed, eg.: a connection related exception happened.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)