You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2014/12/16 06:47:13 UTC
Review Request 29086: LENS-125 negative constants are getting
rewritten incorrectly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29086/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-125
https://issues.apache.org/jira/browse/LENS-125
Repository: lens
Description
-------
Issue occurs because use of unary negative operator is not handled in HQLParser.getString. Added special handling for unary use of minus operator
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 628fc05
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 9e06d20
Diff: https://reviews.apache.org/r/29086/diff/
Testing
-------
Added a test to validate current change.
Reran all existing tests, no failures.
Thanks,
Jaideep dhok
Re: Review Request 29086: LENS-125 negative constants are getting
rewritten incorrectly
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29086/#review65184
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Dec. 16, 2014, 5:47 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29086/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2014, 5:47 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-125
> https://issues.apache.org/jira/browse/LENS-125
>
>
> Repository: lens
>
>
> Description
> -------
>
> Issue occurs because use of unary negative operator is not handled in HQLParser.getString. Added special handling for unary use of minus operator
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 628fc05
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 9e06d20
>
> Diff: https://reviews.apache.org/r/29086/diff/
>
>
> Testing
> -------
>
> Added a test to validate current change.
> Reran all existing tests, no failures.
>
>
> Thanks,
>
> Jaideep dhok
>
>