[GitHub] mistercrunch closed pull request #5587: fix cal_heatmap tips location error (#5480)

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5587: fix cal_heatmap tips location error (#5480)
URL: https://github.com/apache/incubator-superset/pull/5587
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/vendor/cal-heatmap/cal-heatmap.js b/superset/assets/vendor/cal-heatmap/cal-heatmap.js
index 0b00756cb9..0881c9a73e 100644
--- a/superset/assets/vendor/cal-heatmap/cal-heatmap.js
+++ b/superset/assets/vendor/cal-heatmap/cal-heatmap.js
@@ -897,7 +897,7 @@ var CalHeatMap = function() {
         if (options.tooltip) {
           selection
           .on("mouseover", function(d) {
-            self.tip.show(d);
+            self.tip.show(d, this);
           })
           .on("mouseout", function() {
             self.tip.hide(d);
@@ -3285,7 +3285,7 @@ Legend.prototype.redraw = function(width) {
   });
   legendItem
   .on("mouseover", function(d) {
-    calendar.legendTip.show(d);
+    calendar.legendTip.show(d, this);
   })
   .on("mouseout", function() {
     calendar.legendTip.hide();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org