You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/06/25 16:27:52 UTC
[GitHub] [incubator-shenyu-website] skyleaworlder opened a new pull request, #619: PR: Update ci for pdf generation
skyleaworlder opened a new pull request, #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619
Generating pdf every corresponding push time makes repo's size larger and larger (now 600MB+). Using GitHub Actions to generate pdf like #144 is needed, so this PR makes efforts to:
* Adapt the new repo structure of docsaurus;
* Reuse old generate-pdf.sh & workflow to generate pdf now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] dengliming merged pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
dengliming merged PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166417703
@dengliming I think it works well now\~ Please check the log output and @ me if there are still some mistakes\~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] dengliming commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
dengliming commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166415791
> Thank you and I might need another approval about GitHub Actions for I'm new here :)
No worry. you can ping me. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] JooKS-me commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
JooKS-me commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166418289
> Thank you for all the help @JooKS-me and @dengliming have provided.
>
> I will focus and keep an eye out for any follow-up bugs.
Good job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166416421
I feel SO SORRY. I found I just comment "prepare" function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166481310
> @skyleaworlder The old pdf links are written dead. You may need to use https://shenyu.apache.org/pdf/apache_shenyu_docs_en.pdf https://shenyu.apache.org/pdf/apache_shenyu_docs_zh.pdf
Thanks. And I commit this in #620.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166422547
@dengliming Of course it's my pleasure; I'm willing to update it.
But PDF links in [shenyu.apache.org/download](https://shenyu.apache.org/download/) and [shenyu.apache.org/zh/download](https://shenyu.apache.org/zh/download/) are available now.
In addition, the newest PDFs are not uploaded to main branch. From my perspective, if I update these pages, it means that I need to change them to [pdf links under this path](https://github.com/apache/incubator-shenyu-website/tree/asf-site/pdf) (**asf-site** branch). Docsaurus seems to auto-generate pdf links to assets/files. I don't know if my change would destroy something or not.
Sincerely looking forward to reply to my doubts and some thoughtless considerations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] dengliming commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
dengliming commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166469551
@skyleaworlder The old pdf links are written dead. You may need to use https://shenyu.apache.org/pdf/apache_shenyu_docs_en.pdf
https://shenyu.apache.org/pdf/apache_shenyu_docs_zh.pdf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166414759
>  @skyleaworlder
@dengliming Thanks for pointing out the problem. I think this is because download OTF part of generate-pdf.sh in this PR is not correct now. I'll try to invoke GitHub Actions after I fix it.
Thank you and I might need another approval about GitHub Actions for I'm new here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] dengliming commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
dengliming commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166413430
@skyleaworlder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166416159
It's just too strange...
I want to rerun this workflow to check if this is not coincidence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] dengliming commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
dengliming commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166420426
@skyleaworlder Thanks for your contribution. Great job! Can you update the download page?
https://github.com/apache/incubator-shenyu-website/blob/main/i18n/zh/docusaurus-plugin-content-pages/download.md
https://github.com/apache/incubator-shenyu-website/blob/main/src/pages/download.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shenyu-website] skyleaworlder commented on pull request #619: PR: Update ci for pdf generation
Posted by GitBox <gi...@apache.org>.
skyleaworlder commented on PR #619:
URL: https://github.com/apache/incubator-shenyu-website/pull/619#issuecomment-1166418139
Thank you for all the help @JooKS-me and @dengliming have provided.
I will focus and keep an eye out for any follow-up bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org