[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1221:
URL: https://github.com/apache/hive/pull/1221#discussion_r451282795



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java
##########
@@ -123,13 +123,13 @@ public void testGetPartitionsByNamesEmptyParts() throws Exception {
     getClient().getPartitionsByNames(DB_NAME, TABLE_NAME, Lists.newArrayList("", ""));
   }
 
-  @Test(expected = MetaException.class)
+  @Test

Review comment:
       This is test was introduced to check backward compatibility of the HMS API.
   Changing this behavior indicates change in the API. I think we should keep the original Exception.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org