You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by cc...@apache.org on 2023/07/31 15:17:48 UTC

[yunikorn-scheduler-interface] branch master updated: [YUNIKORN-1887] SI: Add tag to allow forcible app creation (#99)

This is an automated email from the ASF dual-hosted git repository.

ccondit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-scheduler-interface.git


The following commit(s) were added to refs/heads/master by this push:
     new 8931af4  [YUNIKORN-1887] SI: Add tag to allow forcible app creation (#99)
8931af4 is described below

commit 8931af4dda266d0485bae50575a62ff25acc8c3b
Author: Craig Condit <cc...@apache.org>
AuthorDate: Mon Jul 31 10:17:35 2023 -0500

    [YUNIKORN-1887] SI: Add tag to allow forcible app creation (#99)
    
    Applications can be created in response to existing allocations
    being reported from the shim to the core. We need to ensure that
    these applications are not rejected.
    
    Closes: #99
---
 lib/go/common/constants.go  | 1 +
 lib/go/si/si.pb.go          | 3 +--
 scheduler-interface-spec.md | 4 ++--
 si.proto                    | 3 +--
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/go/common/constants.go b/lib/go/common/constants.go
index b1d9312..124d93f 100644
--- a/lib/go/common/constants.go
+++ b/lib/go/common/constants.go
@@ -64,5 +64,6 @@ const (
 	AppTagNamespaceResourceQuota      = "namespace.resourcequota"
 	AppTagNamespaceResourceGuaranteed = "namespace.resourceguaranteed"
 	AppTagStateAwareDisable           = "application.stateaware.disable"
+	AppTagCreateForce                 = "application.create.force"
 	NodeReadyAttribute                = "ready"
 )
diff --git a/lib/go/si/si.pb.go b/lib/go/si/si.pb.go
index dc8edcc..51e78a7 100644
--- a/lib/go/si/si.pb.go
+++ b/lib/go/si/si.pb.go
@@ -622,8 +622,7 @@ type AllocationRequest struct {
 	Releases *AllocationReleasesRequest `protobuf:"bytes,2,opt,name=releases,proto3" json:"releases,omitempty"`
 	// ID of RM, this will be used to identify which RM of the request comes from.
 	RmID string `protobuf:"bytes,3,opt,name=rmID,proto3" json:"rmID,omitempty"`
-	// Register new allocations or replace of existing allocations (if allocationID is same).
-	// The ask must already exist, or be specified in the asks parameter of this request.
+	// Existing allocations to be added.
 	Allocations []*Allocation `protobuf:"bytes,4,rep,name=allocations,proto3" json:"allocations,omitempty"`
 }
 
diff --git a/scheduler-interface-spec.md b/scheduler-interface-spec.md
index fb61462..b163314 100644
--- a/scheduler-interface-spec.md
+++ b/scheduler-interface-spec.md
@@ -255,8 +255,7 @@ message AllocationRequest {
   // ID of RM, this will be used to identify which RM of the request comes from.
   string rmID = 3;
 
-  // Register new allocations or replace of existing allocations (if allocationID is same).
-  // The ask must already exist, or be specified in the asks parameter of this request.
+  // Existing allocations to be added.
   repeated Allocation allocations = 4;
 }
 
@@ -745,6 +744,7 @@ const (
 	AppTagNamespaceResourceQuota      = "namespace.resourcequota"
 	AppTagNamespaceResourceGuaranteed = "namespace.resourceguaranteed"
 	AppTagStateAwareDisable           = "application.stateaware.disable"
+	AppTagCreateForce                 = "application.create.force"
 	NodeReadyAttribute                = "ready"
 )
 ```
diff --git a/si.proto b/si.proto
index c48ad88..f14643e 100644
--- a/si.proto
+++ b/si.proto
@@ -84,8 +84,7 @@ message AllocationRequest {
   // ID of RM, this will be used to identify which RM of the request comes from.
   string rmID = 3;
 
-  // Register new allocations or replace of existing allocations (if allocationID is same).
-  // The ask must already exist, or be specified in the asks parameter of this request.
+  // Existing allocations to be added.
   repeated Allocation allocations = 4;
 }
 


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org