You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/30 12:00:33 UTC
[GitHub] [rocketmq] codecov-commenter commented on pull request #3588: [ISSUE 3585] [Part B] Improve encode/decode performance
codecov-commenter commented on pull request #3588:
URL: https://github.com/apache/rocketmq/pull/3588#issuecomment-1002998634
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3588](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f47ef2) into [develop](https://codecov.io/gh/apache/rocketmq/commit/ecb061ae425f76ad28a597293b98f374ceba14ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecb061a) will **decrease** coverage by `2.40%`.
> The diff coverage is `57.95%`.
[](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #3588 +/- ##
=============================================
- Coverage 49.69% 47.29% -2.41%
- Complexity 4725 5052 +327
=============================================
Files 555 628 +73
Lines 36798 41479 +4681
Branches 4853 5409 +556
=============================================
+ Hits 18286 19616 +1330
- Misses 16214 19407 +3193
- Partials 2298 2456 +158
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...broker/processor/AbstractSendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0Fic3RyYWN0U2VuZE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `40.37% <0.00%> (-8.93%)` | :arrow_down: |
| [...he/rocketmq/remoting/protocol/FastCodesHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL0Zhc3RDb2Rlc0hlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...on/protocol/header/SendMessageRequestHeaderV2.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1NlbmRNZXNzYWdlUmVxdWVzdEhlYWRlclYyLmphdmE=) | `23.20% <50.90%> (+23.19%)` | :arrow_up: |
| [...mmon/protocol/header/PullMessageRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1B1bGxNZXNzYWdlUmVxdWVzdEhlYWRlci5qYXZh) | `30.86% <51.06%> (+30.86%)` | :arrow_up: |
| [...mon/protocol/header/PullMessageResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1B1bGxNZXNzYWdlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `34.37% <52.63%> (+34.37%)` | :arrow_up: |
| [...mon/protocol/header/SendMessageResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL1NlbmRNZXNzYWdlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `34.37% <52.63%> (+34.37%)` | :arrow_up: |
| [...he/rocketmq/remoting/protocol/RemotingCommand.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlbW90aW5nQ29tbWFuZC5qYXZh) | `72.83% <61.76%> (-5.80%)` | :arrow_down: |
| [...cketmq/remoting/protocol/RocketMQSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JvY2tldE1RU2VyaWFsaXphYmxlLmphdmE=) | `85.12% <80.35%> (-1.34%)` | :arrow_down: |
| [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1NlbmRNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `39.74% <100.00%> (-0.16%)` | :arrow_down: |
| [...g/apache/rocketmq/remoting/netty/NettyDecoder.java](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5RGVjb2Rlci5qYXZh) | `87.50% <100.00%> (-0.74%)` | :arrow_down: |
| ... and [100 more](https://codecov.io/gh/apache/rocketmq/pull/3588/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ecb061a...4f47ef2](https://codecov.io/gh/apache/rocketmq/pull/3588?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org