You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/07 12:29:39 UTC

[GitHub] [cloudstack] Pearl1594 opened a new pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Pearl1594 opened a new pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958


   ### Description
   
   This PR fixes the issue noticed when listing all ssh key pairs including ones owned by projects. Exception:
   ```
   (primateqa) 🐱 > list sshkeypairs listall=true projectid=-1
   🙈 Error: (HTTP 530, error code 4250) DB Exception on: com.mysql.cj.jdbc.ClientPreparedStatement: SELECT ssh_keypairs.id, ssh_keypairs.uuid, ssh_keypairs.account_id, ssh_keypairs.domain_id, ssh_keypairs.keypair_name, ssh_keypairs.fingerprint, ssh_keypairs.public_key FROM ssh_keypairs  INNER JOIN account ON ssh_keypairs.account_id=account.id  WH ORDER BY ssh_keypairs.id DESC  LIMIT 0, 500
   ```
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   #### Post Fix:
   ```
   (localcloud) 🐱 > list sshkeypairs listall=true page=1 pagesize=20 filter=name,
   {
     "count": 1,
     "sshkeypair": [
       {
         "name": "ssh"
       }
     ]
   }
   (localcloud) 🐱 > list sshkeypairs listall=true projectid=-1 page=1 pagesize=20 filter=name,
   {
     "count": 2,
     "sshkeypair": [
       {
         "name": "test"
       },
       {
         "name": "ssh"
       }
     ]
   }
   ```
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032599478


   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031547550


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031415981


   Created a new PR & closed https://github.com/apache/cloudstack/pull/5815 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032960930


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033285290


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033796027


   <b>Trillian test result (tid-3255)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34467 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5958-t3255-kvm-centos7.zip
   Smoke tests completed. 92 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032598501


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032359405


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032225641


   @Pearl1594 Can you address the outstanding comments. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032358706


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033325259


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032756438


   <b>Trillian Build Failed (tid-3237)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032930453


   <b>Trillian Build Failed (tid-3250)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032556600


   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032930268


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032893988


   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032358706


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032815273


   <b>Trillian Build Failed (tid-3241)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032556058


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033325143


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031421219


   @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031464522


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#discussion_r800744583



##########
File path: framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java
##########
@@ -1287,13 +1289,20 @@ protected void addJoins(StringBuilder str, Collection<JoinBuilder<SearchCriteria
             .append(" ");
             str.insert(fromIndex, onClause);
             String whereClause = join.getT().getWhereClause();
-            if ((whereClause != null) && !"".equals(whereClause)) {
+            if (!StringUtils.isEmpty(whereClause)) {

Review comment:
       ```suggestion
               if (StringUtils.isNotEmpty(whereClause)) {
   ```

##########
File path: framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java
##########
@@ -1287,13 +1289,20 @@ protected void addJoins(StringBuilder str, Collection<JoinBuilder<SearchCriteria
             .append(" ");
             str.insert(fromIndex, onClause);
             String whereClause = join.getT().getWhereClause();
-            if ((whereClause != null) && !"".equals(whereClause)) {
+            if (!StringUtils.isEmpty(whereClause)) {
+                if (!hasWhereClause) {
+                    str.append(" WHERE ");
+                    hasWhereClause = true;
+                }
                 str.append(" (").append(whereClause).append(") AND");
             }
             fromIndex += onClause.length();
         }
 
-        str.delete(str.length() - 4, str.length());
+        if (hasWhereClause) {
+            // Remove ' AND' OR 'AND ' at the end of line
+            str.delete(str.length() - 4, str.length());

Review comment:
       I think it could be a method with an intuitive name instead of a comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031468118


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033287478


   <b>Trillian Build Failed (tid-3253)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033617621


   retested with the latest changes :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033300856


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032596634


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2527


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032395522


   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 2513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031487659


   > tested ok
   
   ok, than I'll refrain from monkeying around


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031546669


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032894459


   @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Pearl1594 commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032929916


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032395522






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032636641


   <b>Trillian Build Failed (tid-3235)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033285569


   @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1031418839


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1032134703


   <b>Trillian test result (tid-3219)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39045 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5958-t3219-kvm-centos7.zip
   Smoke tests completed. 90 look OK, 2 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_redundant_VPC_default_routes | `Failure` | 349.71 | test_vpc_redundant.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 291.77 | test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 76.53 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033301407


   @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5958: API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5958:
URL: https://github.com/apache/cloudstack/pull/5958#issuecomment-1033320973


   Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org