[jira] [Commented] (MAPREDUCE-2445) TestMiniMRWithDFSWithDistinctUsers is very broken

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023091#comment-13023091 ] 

Hadoop QA commented on MAPREDUCE-2445:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12477071/mapreduce-2445.txt
  against trunk revision 1094093.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause tar ant target to fail.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:


    -1 contrib tests.  The patch failed contrib unit tests.

    -1 system test framework.  The patch failed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/177//testReport/
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/177//console

This message is automatically generated.

> TestMiniMRWithDFSWithDistinctUsers is very broken
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2445
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2445
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security, test
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: mapreduce-2445.txt
>
>
> This test has a number of issues:
> - it side steps the normal job submission API for no apparent reason, manually writing splits file and uploading submission files. (but forgets to upload the job jar, so the jobs all fail)
> - it doesn't call waitForCompletion, or check job status (so it doesn't notice that the jobs all fail)
> - it doesn't verify in any way that the job output is owned by the user who supposedly ran the job
> - it shuts down DFS before MR
> These all conspire to make it pass, but it isn't actually testing anything.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira