[Bug 65115] New: Missing key (jsp.error.unable.renameClassFile) in localization file for Russian and Spanish

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65115

            Bug ID: 65115
           Summary: Missing key (jsp.error.unable.renameClassFile) in
                    localization file for Russian and Spanish
           Product: Tomcat 9
           Version: unspecified
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: peter_lenahan@ibi.com
  Target Milestone: -----

I think this is a minor change in the localizations strings file.


The issue is happening when we are testing our Russian localization within our
product.
But I am not sure if tomcat is set to Russian or English when we are testing.

The code seems to be passing the name of the file that it cannot rename,
however not all of the localization files have [{0}] to [{1}]

Caused by: java.io.IOException: tmpFile.renameTo(classFile) failed
        at
org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:207)
~[jasper.jar:8.5.32]
        at org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:166)
~[jasper.jar:8.5.32]

        at ...

Specifically the Russian file LocalStrings_ru.properties is missing this key
jsp.error.unable.renameClassFile=Unable to rename class file from [{0}] to
[{1}]


I think that this is the code that is generating the error. and it appears to
be passing in the filenames that cannot be renamed.  But the message displayed
does not contain the filenames.

if (!tmpFile.renameTo(classFile)) {
                throw new
IOException(Localizer.getMessage("jsp.error.unable.renameClassFile",
                        tmpFile.getAbsolutePath(),
classFile.getAbsolutePath()));
            }

A search of the LocalStrings shows that the  [{0}] to [{1}] is also missing in 
Japan, and Korean and German, and the key is also missing in the Spanish
translation file.


$ grep jsp.error.unable.renameClassFile $(find . -type f )
./tomcat-8.5.x/java/org/apache/jasper/compiler/SmapUtil.java:               
throw new IOException(Localizer.getMessage("jsp.erro
r.unable.renameClassFile",
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings.properties:jsp.error.unable.renameClassFile=Unable
to rename class f
ile from [{0}] to [{1}]
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_de.properties:jsp.error.unable.renameClassFile=Fehler
beim Umbenenne
n der Klassendatei
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_fr.properties:jsp.error.unable.renameClassFile=Impossible
de renomme
r le fichier de classe de [{0}] vers [{1}]
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_ja.properties:jsp.error.unable.renameClassFile=ククララススフファァイイルルのの名名前前
をを変変更更ででききまませせんん
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_ko.properties:jsp.error.unable.renameClassFile=클클래래스스
파파일일의의 이이름름을을
변변경경할할 수수 없없습습니니다다.
./tomcat-8.5.x/java/org/apache/jasper/resources/LocalStrings_zh_CN.properties:jsp.error.unable.renameClassFile=无无法法重重命命名名类类文文件件[{
0}]为为[{1}]

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 65115] Missing key (jsp.error.unable.renameClassFile) in localization file for Russian and Spanish

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65115

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
The Russian text for that key was added to POEditor.com a couple of days ago so
it will be picked up for the next release.

If keys are missing for a language, it will fall-back to using the English
text. Missing keys for a language are not considered bugs.

Help improving translations at POEditor.com is always welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 65115] Missing key (jsp.error.unable.renameClassFile) in localization file for Russian and Spanish

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65115

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
L10n strings are managed via POEditor.com

https://cwiki.apache.org/confluence/display/TOMCAT/Managing+translations

I've corrected, with the help of Google translate, the translations that were
missing the placeholders.

We typically import updated translations just before we do a release so these
should be picked up at the end of February for the March release.

We have some utilities that back-port strings between versions. I'd have
expected this to have back-ported the "jsp.error.unable.renameClassFile" key
for Russian. I'll take a look and see why this did not happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org