You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/06/02 13:10:44 UTC
Review Request 59746: Separated discarded and failed cases for
container launch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
Bugs: MESOS-7601
https://issues.apache.org/jira/browse/MESOS-7601
Repository: mesos
Description
-------
Discarded future returned from the containerizer->launch() does not
necessarily mean that the container launch has failed. For example,
a framework may stop while its task are being started.
Diffs
-----
include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
Diff: https://reviews.apache.org/r/59746/diff/1/
Testing
-------
make check on several Linux distros.
Thanks,
Alexander Rukletsov
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On June 2, 2017, 3:39 p.m., Jan Schlicht wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Should we also cover the `PENDING` state of a future? `!future.isReady()` could also mean that it's in `PENDING` state. The old code (wrongly) logged a "future discarded" but covered that case.
>
> Alexander Rukletsov wrote:
> I don't think so. IIUC, this continuation is only called when a future, on which this continuation is chained, has entered a terminal state. However, it might make sense to `CHECK` that the future is not pending, since we consider this an internal invariant.
Agreed, a `CHECK` makes sense here as we wouldn't expect a `PENDING` state at this point.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176766
-----------------------------------------------------------
On June 2, 2017, 3:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 3:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On June 2, 2017, 1:39 p.m., Jan Schlicht wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Should we also cover the `PENDING` state of a future? `!future.isReady()` could also mean that it's in `PENDING` state. The old code (wrongly) logged a "future discarded" but covered that case.
I don't think so. IIUC, this continuation is only called when a future, on which this continuation is chained, has entered a terminal state. However, it might make sense to `CHECK` that the future is not pending, since we consider this an internal invariant.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176766
-----------------------------------------------------------
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Stopped accounting aborted container
launches as failures.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On June 2, 2017, 1:39 p.m., Jan Schlicht wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Should we also cover the `PENDING` state of a future? `!future.isReady()` could also mean that it's in `PENDING` state. The old code (wrongly) logged a "future discarded" but covered that case.
>
> Alexander Rukletsov wrote:
> I don't think so. IIUC, this continuation is only called when a future, on which this continuation is chained, has entered a terminal state. However, it might make sense to `CHECK` that the future is not pending, since we consider this an internal invariant.
>
> Jan Schlicht wrote:
> Agreed, a `CHECK` makes sense here as we wouldn't expect a `PENDING` state at this point.
We don't have such checks in the rest of the file (not in master.cpp). Given I'm going a different way now, I'll punt on this.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176766
-----------------------------------------------------------
On Aug. 22, 2017, 1:47 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 1:47 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The container launch future might be failed or discarded (depending
> on the containerizer implementation) if the launch has been aborted,
> for example, a framework might have stopped while its task are being
> started. Such failures should not be accounted as launch errors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/59746/diff/2/
>
>
> Testing
> -------
>
> `make check` on several Linux distros.
>
> Additional manual tests for (1) mesos and (1) docker containerizers. The framework is asked to exit right after it submits the task to mesos.
>
> (1) With mesos c-zer
> m: `./bin/mesos-master.sh --work_dir=./m`
> a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=mesos --image_providers="DOCKER" --isolation=filesystem/linux,docker/runtime`
> f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
>
> (2) With docker c-zer
> m: `./bin/mesos-master.sh --work_dir=./m`
> a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=docker`
> f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176766
-----------------------------------------------------------
src/slave/slave.cpp
Line 5147 (original), 5147 (patched)
<https://reviews.apache.org/r/59746/#comment250234>
Should we also cover the `PENDING` state of a future? `!future.isReady()` could also mean that it's in `PENDING` state. The old code (wrongly) logged a "future discarded" but covered that case.
- Jan Schlicht
On June 2, 2017, 3:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 3:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Stopped accounting aborted container
launches as failures.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review183473
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61811, 59746]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 22, 2017, 4:47 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 4:47 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The container launch future might be failed or discarded (depending
> on the containerizer implementation) if the launch has been aborted,
> for example, a framework might have stopped while its task are being
> started. Such failures should not be accounted as launch errors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/59746/diff/2/
>
>
> Testing
> -------
>
> `make check` on several Linux distros.
>
> Additional manual tests for (1) mesos and (1) docker containerizers. The framework is asked to exit right after it submits the task to mesos.
>
> (1) With mesos c-zer
> m: `./bin/mesos-master.sh --work_dir=./m`
> a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=mesos --image_providers="DOCKER" --isolation=filesystem/linux,docker/runtime`
> f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
>
> (2) With docker c-zer
> m: `./bin/mesos-master.sh --work_dir=./m`
> a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=docker`
> f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Stopped accounting aborted container
launches as failures.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 5:17 p.m.)
Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
Bugs: MESOS-7601
https://issues.apache.org/jira/browse/MESOS-7601
Repository: mesos
Description
-------
The container launch future might be failed or discarded (depending
on the containerizer implementation) if the launch has been aborted,
for example, a framework might have stopped while its task are being
started. Such failures should not be accounted as launch errors.
Diffs (updated)
-----
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
Diff: https://reviews.apache.org/r/59746/diff/3/
Changes: https://reviews.apache.org/r/59746/diff/2-3/
Testing
-------
`make check` on several Linux distros.
Additional manual tests for (1) mesos and (1) docker containerizers. The framework is asked to exit right after it submits the task to mesos.
(1) With mesos c-zer
m: `./bin/mesos-master.sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=mesos --image_providers="DOCKER" --isolation=filesystem/linux,docker/runtime`
f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
(2) With docker c-zer
m: `./bin/mesos-master.sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=docker`
f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
Thanks,
Alexander Rukletsov
Re: Review Request 59746: Stopped accounting aborted container
launches as failures.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 1:47 p.m.)
Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
Changes
-------
Employed a different approach: ignore both failures and discards if executor has been asked to shutdown.
Summary (updated)
-----------------
Stopped accounting aborted container launches as failures.
Bugs: MESOS-7601
https://issues.apache.org/jira/browse/MESOS-7601
Repository: mesos
Description (updated)
-------
The container launch future might be failed or discarded (depending
on the containerizer implementation) if the launch has been aborted,
for example, a framework might have stopped while its task are being
started. Such failures should not be accounted as launch errors.
Diffs (updated)
-----
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
Diff: https://reviews.apache.org/r/59746/diff/2/
Changes: https://reviews.apache.org/r/59746/diff/1-2/
Testing (updated)
-------
`make check` on several Linux distros.
Additional manual tests for (1) mesos and (1) docker containerizers. The framework is asked to exit right after it submits the task to mesos.
(1) With mesos c-zer
m: `./bin/mesos-master.sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=mesos --image_providers="DOCKER" --isolation=filesystem/linux,docker/runtime`
f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
(2) With docker c-zer
m: `./bin/mesos-master.sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=docker`
f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
Thanks,
Alexander Rukletsov
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176763
-----------------------------------------------------------
Ship it!
Nice addition, LGTM.
- Armand Grillet
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Stopped accounting aborted container
launches as failures.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On June 2, 2017, 6:34 p.m., Gastón Kleiman wrote:
> > src/slave/slave.cpp
> > Lines 5162 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5162>
> >
> > I don't think that including "future discarded" in the message is useful for framework developers.
> >
> > It is an implementation detail and they shouldn't have to dig in the code to find where it comes from.
Agree in general. Dropping this since the approach has changed.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176820
-----------------------------------------------------------
On Aug. 22, 2017, 1:47 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 1:47 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The container launch future might be failed or discarded (depending
> on the containerizer implementation) if the launch has been aborted,
> for example, a framework might have stopped while its task are being
> started. Such failures should not be accounted as launch errors.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/59746/diff/2/
>
>
> Testing
> -------
>
> `make check` on several Linux distros.
>
> Additional manual tests for (1) mesos and (1) docker containerizers. The framework is asked to exit right after it submits the task to mesos.
>
> (1) With mesos c-zer
> m: `./bin/mesos-master.sh --work_dir=./m`
> a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=mesos --image_providers="DOCKER" --isolation=filesystem/linux,docker/runtime`
> f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
>
> (2) With docker c-zer
> m: `./bin/mesos-master.sh --work_dir=./m`
> a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=docker`
> f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker --docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176820
-----------------------------------------------------------
src/slave/slave.cpp
Lines 5162 (patched)
<https://reviews.apache.org/r/59746/#comment250299>
I don't think that including "future discarded" in the message is useful for framework developers.
It is an implementation detail and they shouldn't have to dig in the code to find where it comes from.
- Gastón Kleiman
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On June 2, 2017, 4:37 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Can you explain to me in what scenario, the `future` will be in DISCARDED state? who discard the promise associated with this future?
>
> Alexander Rukletsov wrote:
> Sure. Consider docker containerizer.
>
> 1) During container launch, docker containerizer calls `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1238
> 2) The container enters `PULLING` state: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L435
> 3) While the image is being pulled by docker, future `containers_[containerId]->pull` is returned from `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L446
> 4) This future is part of the `.then` chain returned from `_launch()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1269
> 5) Now while docker is pulling, `destroy()` is called, which discards the "pulling future": https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
> 6) But discarding that future is propagated up the chain: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/3rdparty/libprocess/include/process/future.hpp#L1410-L1411
> 7) Which triggers the `onAny` callback attached to launch: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L2800-L2810
> 8) Which in turn gives us discarded future treated as launch error: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L5147-L5152
>
> Jie Yu wrote:
> https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
>
> This discards the future, but not necessarily transition the future to DISCARDED state. That's the reason we have `hasDiscard` and `isDiscarded` methods for Future becaue they means different things. Can you point to me where the promise associated with this future is actually being transitioned into DISCARDED state?
>
> Alexander Rukletsov wrote:
> Sure. In this case, we discard pulling in case client discarded the future: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/docker/docker.cpp#L1512
>
> Additionally, I've manually reproduced the issue (https://issues.apache.org/jira/browse/MESOS-7601)
> ```
> ./src/mesos-execute --master=192.99.40.208:5050 --containerizer=docker --docker_image=ubuntu:16.04 --name=pull-test --command="sleep 1000"
> ```
> aborted right after the start when docker was pulling the image yielded the following verbose agent log:
> ```
> I0621 12:59:22.271728 28980 fetcher.cpp:324] Starting to fetch URIs for container: e2227d2f-fb6e-4fba-b6b6-528d2da7b276, directory: /tmp/a/slaves/f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-S0/frameworks/f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003/executors/pull-test/runs/e2227d2f-fb6e-4fba-b6b6-528d2da7b276
> I0621 12:59:22.272665 28989 docker.cpp:1352] Running docker -H unix:///var/run/docker.sock inspect ubuntu:16.04
> I0621 12:59:22.420902 28990 docker.cpp:1426] Running docker -H unix:///var/run/docker.sock pull ubuntu:16.04
> I0621 12:59:23.070950 28980 slave.cpp:3130] Asked to shut down framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003 by master@192.99.40.208:5050
> I0621 12:59:23.071007 28980 slave.cpp:3155] Shutting down framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
> I0621 12:59:23.071146 28980 slave.cpp:5625] Shutting down executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
> W0621 12:59:23.071171 28980 slave.hpp:732] Unable to send event to executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003: unknown connection type
> I0621 12:59:28.072532 28984 slave.cpp:5698] Killing executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
> I0621 12:59:28.072849 28985 docker.cpp:2125] Destroying container e2227d2f-fb6e-4fba-b6b6-528d2da7b276 in PULLING state
> I0621 12:59:28.073074 28985 docker.cpp:149] 'docker -H unix:///var/run/docker.sock pull ubuntu:16.04' is being discarded
> E0621 12:59:28.150388 28981 slave.cpp:5183] Container 'e2227d2f-fb6e-4fba-b6b6-528d2da7b276' for executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003 failed to start: future discarded
> E0621 12:59:28.150698 28978 slave.cpp:5290] Termination of executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003 failed: unknown container
> W0621 12:59:28.150737 28985 composing.cpp:569] Attempted to destroy unknown container e2227d2f-fb6e-4fba-b6b6-528d2da7b276
> I0621 12:59:28.150754 28978 slave.cpp:5403] Cleaning up executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
> ```
>
> I believe killing the process tree leads to discarded future returned by `Subprocess` call.
>
> The question here, I think, is whether it is safe to _always_ treat discarded container launch attempts as non-failures. I would argue it makes sense, because for failures we should use future failures : ). What do you think?
I've realised that I have not answered your question explicitly : ). So when `docker pull` is forcefully killed and the corresponding process is reaped, the `subprocess.status` future is set to ready, but the chained one (`___pull` if my mental compiler works correctly) transitions to `discarded` because of [1], leading to the original `launch` future being discarded as well.
[1] https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/3rdparty/libprocess/include/process/future.hpp#L1297
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176789
-----------------------------------------------------------
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On June 2, 2017, 4:37 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Can you explain to me in what scenario, the `future` will be in DISCARDED state? who discard the promise associated with this future?
>
> Alexander Rukletsov wrote:
> Sure. Consider docker containerizer.
>
> 1) During container launch, docker containerizer calls `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1238
> 2) The container enters `PULLING` state: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L435
> 3) While the image is being pulled by docker, future `containers_[containerId]->pull` is returned from `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L446
> 4) This future is part of the `.then` chain returned from `_launch()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1269
> 5) Now while docker is pulling, `destroy()` is called, which discards the "pulling future": https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
> 6) But discarding that future is propagated up the chain: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/3rdparty/libprocess/include/process/future.hpp#L1410-L1411
> 7) Which triggers the `onAny` callback attached to launch: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L2800-L2810
> 8) Which in turn gives us discarded future treated as launch error: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L5147-L5152
>
> Jie Yu wrote:
> https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
>
> This discards the future, but not necessarily transition the future to DISCARDED state. That's the reason we have `hasDiscard` and `isDiscarded` methods for Future becaue they means different things. Can you point to me where the promise associated with this future is actually being transitioned into DISCARDED state?
Sure. In this case, we discard pulling in case client discarded the future: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/docker/docker.cpp#L1512
Additionally, I've manually reproduced the issue (https://issues.apache.org/jira/browse/MESOS-7601)
```
./src/mesos-execute --master=192.99.40.208:5050 --containerizer=docker --docker_image=ubuntu:16.04 --name=pull-test --command="sleep 1000"
```
aborted right after the start when docker was pulling the image yielded the following verbose agent log:
```
I0621 12:59:22.271728 28980 fetcher.cpp:324] Starting to fetch URIs for container: e2227d2f-fb6e-4fba-b6b6-528d2da7b276, directory: /tmp/a/slaves/f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-S0/frameworks/f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003/executors/pull-test/runs/e2227d2f-fb6e-4fba-b6b6-528d2da7b276
I0621 12:59:22.272665 28989 docker.cpp:1352] Running docker -H unix:///var/run/docker.sock inspect ubuntu:16.04
I0621 12:59:22.420902 28990 docker.cpp:1426] Running docker -H unix:///var/run/docker.sock pull ubuntu:16.04
I0621 12:59:23.070950 28980 slave.cpp:3130] Asked to shut down framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003 by master@192.99.40.208:5050
I0621 12:59:23.071007 28980 slave.cpp:3155] Shutting down framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
I0621 12:59:23.071146 28980 slave.cpp:5625] Shutting down executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
W0621 12:59:23.071171 28980 slave.hpp:732] Unable to send event to executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003: unknown connection type
I0621 12:59:28.072532 28984 slave.cpp:5698] Killing executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
I0621 12:59:28.072849 28985 docker.cpp:2125] Destroying container e2227d2f-fb6e-4fba-b6b6-528d2da7b276 in PULLING state
I0621 12:59:28.073074 28985 docker.cpp:149] 'docker -H unix:///var/run/docker.sock pull ubuntu:16.04' is being discarded
E0621 12:59:28.150388 28981 slave.cpp:5183] Container 'e2227d2f-fb6e-4fba-b6b6-528d2da7b276' for executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003 failed to start: future discarded
E0621 12:59:28.150698 28978 slave.cpp:5290] Termination of executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003 failed: unknown container
W0621 12:59:28.150737 28985 composing.cpp:569] Attempted to destroy unknown container e2227d2f-fb6e-4fba-b6b6-528d2da7b276
I0621 12:59:28.150754 28978 slave.cpp:5403] Cleaning up executor 'pull-test' of framework f123fa01-fe6e-45f4-b0a9-022b0fc3ce26-0003
```
I believe killing the process tree leads to discarded future returned by `Subprocess` call.
The question here, I think, is whether it is safe to _always_ treat discarded container launch attempts as non-failures. I would argue it makes sense, because for failures we should use future failures : ). What do you think?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176789
-----------------------------------------------------------
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Jie Yu <yu...@gmail.com>.
> On June 2, 2017, 4:37 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Can you explain to me in what scenario, the `future` will be in DISCARDED state? who discard the promise associated with this future?
>
> Alexander Rukletsov wrote:
> Sure. Consider docker containerizer.
>
> 1) During container launch, docker containerizer calls `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1238
> 2) The container enters `PULLING` state: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L435
> 3) While the image is being pulled by docker, future `containers_[containerId]->pull` is returned from `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L446
> 4) This future is part of the `.then` chain returned from `_launch()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1269
> 5) Now while docker is pulling, `destroy()` is called, which discards the "pulling future": https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
> 6) But discarding that future is propagated up the chain: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/3rdparty/libprocess/include/process/future.hpp#L1410-L1411
> 7) Which triggers the `onAny` callback attached to launch: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L2800-L2810
> 8) Which in turn gives us discarded future treated as launch error: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L5147-L5152
https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
This discards the future, but not necessarily transition the future to DISCARDED state. That's the reason we have `hasDiscard` and `isDiscarded` methods for Future becaue they means different things. Can you point to me where the promise associated with this future is actually being transitioned into DISCARDED state?
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176789
-----------------------------------------------------------
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On June 2, 2017, 4:37 p.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Line 5147 (original), 5147 (patched)
> > <https://reviews.apache.org/r/59746/diff/1/?file=1740554#file1740554line5147>
> >
> > Can you explain to me in what scenario, the `future` will be in DISCARDED state? who discard the promise associated with this future?
Sure. Consider docker containerizer.
1) During container launch, docker containerizer calls `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1238
2) The container enters `PULLING` state: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L435
3) While the image is being pulled by docker, future `containers_[containerId]->pull` is returned from `pull()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L446
4) This future is part of the `.then` chain returned from `_launch()`: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L1269
5) Now while docker is pulling, `destroy()` is called, which discards the "pulling future": https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/containerizer/docker.cpp#L2126-L2128
6) But discarding that future is propagated up the chain: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/3rdparty/libprocess/include/process/future.hpp#L1410-L1411
7) Which triggers the `onAny` callback attached to launch: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L2800-L2810
8) Which in turn gives us discarded future treated as launch error: https://github.com/apache/mesos/blob/9e61b3c7af35a29664361067c0bfa8b460bfefb9/src/slave/slave.cpp#L5147-L5152
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176789
-----------------------------------------------------------
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176789
-----------------------------------------------------------
src/slave/slave.cpp
Line 5147 (original), 5147 (patched)
<https://reviews.apache.org/r/59746/#comment250270>
Can you explain to me in what scenario, the `future` will be in DISCARDED state? who discard the promise associated with this future?
- Jie Yu
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176821
-----------------------------------------------------------
src/slave/slave.cpp
Lines 5152 (patched)
<https://reviews.apache.org/r/59746/#comment250300>
We might want to have a metric called `aborted_container_launches` or something like that.
If a framework is expected not to stop until no more tasks are running, operators could monitor this metric and be alerted if there's a bug.
- Gastón Kleiman
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 59746: Separated discarded and failed cases for
container launch.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/#review176769
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59746]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 2, 2017, 1:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59746/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Bugs: MESOS-7601
> https://issues.apache.org/jira/browse/MESOS-7601
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Discarded future returned from the containerizer->launch() does not
> necessarily mean that the container launch has failed. For example,
> a framework may stop while its task are being started.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc
> include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402
> src/slave/slave.cpp 0c7e5f4ef905b3897d341c3147a208fc7a8a12e0
>
>
> Diff: https://reviews.apache.org/r/59746/diff/1/
>
>
> Testing
> -------
>
> make check on several Linux distros.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>