You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2016/03/02 02:49:02 UTC
Re: Review Request 43687: RANGER-838 : Tag-sync should be resilient to
Ranger Admin availability
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43687/#review121563
-----------------------------------------------------------
Fix it, then Ship it!
tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java (line 215)
<https://reviews.apache.org/r/43687/#comment183304>
InterruptedException handler is not needed.
tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java (line 115)
<https://reviews.apache.org/r/43687/#comment183303>
return true;
tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java (line 196)
<https://reviews.apache.org/r/43687/#comment183305>
return true;
- Madhan Neethiraj
On March 2, 2016, 1:11 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43687/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 1:11 a.m.)
>
>
> Review request for ranger, Alok Lal and Madhan Neethiraj.
>
>
> Bugs: RANGER-838
> https://issues.apache.org/jira/browse/RANGER-838
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-838 : Tag-sync should be resilient to Ranger Admin availability
>
>
> Diffs
> -----
>
> tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java d6baeb2
> tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSink.java 9eb5319
> tagsync/src/main/java/org/apache/ranger/tagsync/model/TagSource.java 7d19562
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSyncConfig.java ed8679a
> tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java 696ce5e
> tagsync/src/main/java/org/apache/ranger/tagsync/sink/tagadmin/TagAdminRESTSink.java 1541034
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java 2499177
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 9d9f25d
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java 7f4676a
> tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java e339d5e
>
> Diff: https://reviews.apache.org/r/43687/diff/
>
>
> Testing
> -------
>
> Tested by killing Ranger-Admin, Kafka, Atlas when ranger-admin was running
>
>
> Thanks,
>
> Abhay Kulkarni
>
>