[jira] [Commented] (COMPRESS-302) Retore immutability to ArchiveStremFactory

["Stefan Bodewig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COMPRESS-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322136#comment-14322136 ] 

Stefan Bodewig commented on COMPRESS-302:
-----------------------------------------

+1

you may want to cache getEntryEncoding in a local variable, but that's picking nits.  And maybe add a hint about the new exception to setEntryEncoding's javadoc.

> Retore immutability to ArchiveStremFactory
> ------------------------------------------
>
>                 Key: COMPRESS-302
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-302
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: COMPRESS-302.patch
>
>
> COMPRESS-180 added support for encoding.
> Unfortunately this was done in a way that broke immutability.
> Also the factory is no longer thread-safe as the encoding field is not synch/volatile.
> Consider whether to restore immutability, e.g. by adding a constuctor which takes the encoding setting. The setEntryEncoding method could be deprecated intitially and eventually dropped.
> One way to support immutability now would be to add a second final encoding field which is set by a new ctor. See patch to follow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)