[GitHub] [maven] MartinKanters commented on a change in pull request #435: [MNG-7032] Evaluate --help and --version after configuring the logging/color

[GitBox <gi...@apache.org>]

MartinKanters commented on a change in pull request #435:
URL: https://github.com/apache/maven/pull/435#discussion_r625883295



##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -423,7 +426,10 @@ void cli( CliRequest cliRequest )
             cliManager.displayHelp( System.out );
             throw e;
         }
+    }
 
+    private void command( CliRequest cliRequest ) throws ExitException

Review comment:
       I don't think `command` is the best name we can give this method, especially since we have `commands` already.
   
   Not really happy with it either, but perhaps something like `informativeCommands`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org