You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/09/01 17:08:47 UTC
[PR] refactor(server): split the dispatch spine into plane-named leaves [iggy]
hubcio opened a new pull request, #4026:
URL: https://github.com/apache/iggy/pull/4026
dispatch.rs carried 3.8k production lines in one file: the request
funnel, the session lifecycle, both ends of three mesh protocols
(partition reads, metadata submit, forwarded register/logout), and
the non-replicated read arms sat 1900-2900 lines apart, and the
auth<->dispatch import cycle was the last one in the crate.
Pure motion, no behavior change. The file becomes dispatch/ with
role-named leaves along the request lifecycle: session_ops.rs
(login/register/logout merged from auth.rs and login_register.rs,
plus evictions, the heartbeat verifier, and both ends of the
forwarded register/logout protocol), partition.rs (the partition
data plane, mesh server and client sides on one page), reads.rs
(the non-replicated router and arms), submit.rs (the shard-0
metadata-submit RPC), with the funnel and per-client queue plumbing
staying in mod.rs. The login merge dissolves the auth<->dispatch
cycle, so the module-graph guard whitelist is now empty and can
only stay that way.
One placement differs from the plan: submit_register_on_owner and
submit_logout_on_owner live in session_ops.rs, not submit.rs --
the login and logout paths call them while the submit handler's
arms call back into session_ops, so the planned split would have
traded the dead cycle for a session_ops<->submit one. The shared
test harness moved to dispatch/test_support.rs; each leaf keeps
its own tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(server): split the dispatch spine into plane-named leaves [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4026:
URL: https://github.com/apache/iggy/pull/4026#issuecomment-5497720287
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4026?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 84.54%. Comparing base ([`e362c0f`](https://app.codecov.io/gh/apache/iggy/commit/e362c0f0dcfcd1b6b52b071f6de3d6727f309c9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7c4d66e`](https://app.codecov.io/gh/apache/iggy/commit/7c4d66ef641a448556fc5fbd7b815b5f09e4c600?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4026 +/- ##
============================================
- Coverage 84.98% 84.54% -0.45%
Complexity 1402 1402
============================================
Files 1226 1224 -2
Lines 180701 180444 -257
Branches 147005 146953 -52
============================================
- Hits 153575 152558 -1017
- Misses 23070 23822 +752
- Partials 4056 4064 +8
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.88% <ø> (-0.01%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.29% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.37% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.06% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.65% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.92% <ø> (-6.33%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.31% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4026?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/server/src/bootstrap.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fbootstrap.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2Jvb3RzdHJhcC5ycw==) | `80.13% <ø> (-0.02%)` | :arrow_down: |
| [core/server/src/dispatch/authz.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fdispatch%2Fauthz.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2Rpc3BhdGNoL2F1dGh6LnJz) | `94.64% <ø> (-0.14%)` | :arrow_down: |
| [core/server/src/http/extractor.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fhttp%2Fextractor.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2h0dHAvZXh0cmFjdG9yLnJz) | `85.24% <ø> (ø)` | |
| [core/server/src/http/handlers.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fhttp%2Fhandlers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2h0dHAvaGFuZGxlcnMucnM=) | `79.53% <ø> (ø)` | |
| [core/server/src/http/reply.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fhttp%2Freply.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2h0dHAvcmVwbHkucnM=) | `90.03% <ø> (ø)` | |
| [core/server/src/http/state.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fhttp%2Fstate.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2h0dHAvc3RhdGUucnM=) | `88.42% <ø> (ø)` | |
| [core/server/src/http/submit.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fhttp%2Fsubmit.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL2h0dHAvc3VibWl0LnJz) | `87.30% <ø> (ø)` | |
| [core/server/src/partition\_reconciler.rs](https://app.codecov.io/gh/apache/iggy/pull/4026?src=pr&el=tree&filepath=core%2Fserver%2Fsrc%2Fpartition_reconciler.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXIvc3JjL3BhcnRpdGlvbl9yZWNvbmNpbGVyLnJz) | `97.82% <ø> (ø)` | |
... and [55 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4026/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(server): split the dispatch spine into plane-named leaves [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #4026:
URL: https://github.com/apache/iggy/pull/4026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org