[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #153: [Baseline] Apply baseline linting to iceberg-core

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #153: [Baseline] Apply baseline linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#discussion_r274054791
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
 ##########
 @@ -100,13 +92,14 @@ protected void refreshFromMetadataLocation(String newLocation) {
   protected void refreshFromMetadataLocation(String newLocation, int numRetries) {
     // use null-safe equality check because new tables have a null metadata location
     if (!Objects.equal(currentMetadataLocation, newLocation)) {
-      LOG.info("Refreshing table metadata from new version: " + newLocation);
+      LOG.info("Refreshing table metadata from new version: {}", newLocation);
 
       Tasks.foreach(newLocation)
-          .retry(numRetries).exponentialBackoff(100, 5000, 600000, 4.0 /* 100, 400, 1600, ... */ )
+          .retry(numRetries).exponentialBackoff(100, 5000, 600000, 4.0 /* 100, 400, 1600, ... */)
           .suppressFailureWhenFinished()
           .run(metadataLocation -> {
-            this.currentMetadata = read(this, fromLocation(metadataLocation, conf));
+            this.currentMetadata = TableMetadataParser.read(
+              this, HadoopInputFile.fromLocation(metadataLocation, conf));
 
 Review comment:
   Shouldn't this use a continuation indent?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org