You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ju...@apache.org on 2010/04/07 16:41:00 UTC
svn commit: r931568 - in /subversion/trunk/subversion: include/svn_io.h
libsvn_subr/io.c
Author: julianfoad
Date: Wed Apr 7 14:41:00 2010
New Revision: 931568
URL: http://svn.apache.org/viewvc?rev=931568&view=rev
Log:
Document the behaviour of svn_io_check_path() on invalid pathnames.
A follow-up to r877014.
* subversion/include/svn_io.h
(svn_io_check_path): Document that invalid paths are reported as kind
'svn_node_none'.
* subversion/libsvn_subr/io.c
(io_check_path): Document why an extra check is present on Windows.
Modified:
subversion/trunk/subversion/include/svn_io.h
subversion/trunk/subversion/libsvn_subr/io.c
Modified: subversion/trunk/subversion/include/svn_io.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_io.h?rev=931568&r1=931567&r2=931568&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_io.h (original)
+++ subversion/trunk/subversion/include/svn_io.h Wed Apr 7 14:41:00 2010
@@ -93,8 +93,9 @@ typedef struct svn_io_dirent_t {
* If @a path exists but is none of the above, set @a *kind to
* #svn_node_unknown.
*
- * If unable to determine @a path's kind, return an error, with @a *kind's
- * value undefined.
+ * If @a path is not a valid pathname, set @a *kind to #svn_node_none. If
+ * unable to determine @a path's kind for any other reason, return an error,
+ * with @a *kind's value undefined.
*
* Use @a pool for temporary allocations.
*
Modified: subversion/trunk/subversion/libsvn_subr/io.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/io.c?rev=931568&r1=931567&r2=931568&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/io.c (original)
+++ subversion/trunk/subversion/libsvn_subr/io.c Wed Apr 7 14:41:00 2010
@@ -224,6 +224,9 @@ io_check_path(const char *path,
*kind = svn_node_none;
else if (APR_STATUS_IS_ENOTDIR(apr_err)
#ifdef WIN32
+ /* On Windows, APR_STATUS_IS_ENOTDIR includes several kinds of
+ * invalid-pathname error but not this one, so we include it. */
+ /* ### This fix should go into APR. */
|| (APR_TO_OS_ERROR(apr_err) == ERROR_INVALID_NAME)
#endif
)