You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/07/01 08:23:03 UTC

[GitHub] [submarine] ByronHsu commented on a change in pull request #630: SUBMARINE-886. Underscore character is invalid for experiment name

ByronHsu commented on a change in pull request #630:
URL: https://github.com/apache/submarine/pull/630#discussion_r662084283



##########
File path: submarine-workbench/workbench-web/src/app/pages/workbench/experiment/experiment-home/experiment-form/experiment-customized-form/experiment-customized-form.component.html
##########
@@ -41,6 +41,9 @@
             formControlName="experimentName"
             placeholder="mnist-example"
           />
+          <div class="alert-message" *ngIf="experiment.get('experimentName').hasError('pattern')">
+            Invalid characters exist!

Review comment:
       Maybe we can replace the message with something like "only [a-zA-Z0-9\-] is allowed" to be more clear?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org