You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "heubeck (via GitHub)" <gi...@apache.org> on 2024/01/07 14:08:48 UTC

[I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

heubeck opened a new issue, #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53

   When running 
   
   ```
   answer build --with github.com/apache/incubator-answer-plugins/search-meilisearch
   ```
   
   If fails with 
   
   ```
   [go build -ldflags -X github.com/apache/incubator-answer/cmd.Version=1.2.1 -X github.com/apache/incubator-answer/cmd.Revision=3f696b6 -X github.com/apache/incubator-answer/cmd.Time=1702543995 -o /new_answer .]
   # github.com/apache/incubator-answer-plugins/search-meilisearch
   vendor/github.com/apache/incubator-answer-plugins/search-meilisearch/meilisearch.go:327:70: cannot use tagGroup (variable of type string) as []string value in argument to strings.Join
   build failed exit status 1
   ```
   
   Tried also different refs like  `github.com/apache/incubator-answer-plugins/search-meilisearch@main`, did not manage to get around the error.
   
   `answer -v`: 
   
   ```
   answer version 1.2.1
   revision: 3f696b6
   build time: 1702543995
   ```
   
   build environment based on the official answer docker image: 
   
   ```
   FROM apache/answer:1.2.1 as builder
   
   RUN apk --no-cache add \
       build-base git bash nodejs npm go && \
       npm install -g pnpm
   
   RUN answer build \
       --with github.com/apache/incubator-answer-plugins/connector-basic \
       --with github.com/apache/incubator-answer-plugins/search-meilisearch \
       --output /usr/local/bin/answer_with_plugins
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "hbsciw (via GitHub)" <gi...@apache.org>.
hbsciw commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1880857070

   @LinkinStars Can you suggest Any workaround to build with meilisearch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1882393844

   > > > Will there be git tags / GH releases with the same version like answer itself, to allow a proper mapping?
   > > 
   > > 
   > > Since all plugins are inside one repository, maybe it is not possible to mark the versions of all plugins with a single git tag.
   > 
   > get the issue, nevertheless there needs to be a checkpoint for all of them for each answer version.
   > 
   > maybe some tag name convention containing the plugin name and compatible answer version? that tag would need to point to always the latest compatible commit of a plugin, and `answer build` would need to respect it.
   > 
   > 🤔
   
   Sounds good. We can fix what you said with the `search-meilisearch/v1.2.1` tag. For example, for now you can do it via 
   `./answer build --with github.com/apache/incubator-answer-plugins/search-meilisearch@v1.2.1` command to pull this version of the plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "heubeck (via GitHub)" <gi...@apache.org>.
heubeck commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1880959429

   yes, the references are the same:
   
   ![image](https://github.com/apache/incubator-answer-plugins/assets/40993644/b8476a06-c16d-4ce5-b5e9-011e082c5bde)
   
   I'm testing within a docker build, so no caches at all.
   
   thx for caring :heart_decoration: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "heubeck (via GitHub)" <gi...@apache.org>.
heubeck commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1882736418

   > Sounds good. We can fix what you said with the `search-meilisearch/v1.2.1` tag. For example, for now you can do it via `./answer build --with github.com/apache/incubator-answer-plugins/search-meilisearch@v1.2.1` command to pull this version of the plugin.
   
   awesome, thx, @LinkinStars.
   Can you create similar tags for the other plugins as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1880950457

   @hbsciw I've made some fixes, but gomod may have cache. Just make sure the two version numbers in the image below are correct.
   
   <img width="1394" alt="image" src="https://github.com/apache/incubator-answer-plugins/assets/19712692/c96f2868-760c-4fb3-b6a7-05deb5544127">
   
   <img width="1889" alt="image" src="https://github.com/apache/incubator-answer-plugins/assets/19712692/4d475dc8-a702-4c6c-b099-bfd2814a1c0e">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1881078236

   > Will there be git tags / GH releases with the same version like answer itself, to allow a proper mapping?
   
   Since all plugins are inside one repository, maybe it is not possible to mark the versions of all plugins with a single git tag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "heubeck (via GitHub)" <gi...@apache.org>.
heubeck commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1887029500

   Thx so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1880885913

   @hgaol https://github.com/apache/incubator-answer-plugins/blob/0c16db54b98f2d156fdc476e12b0f51355453325/search-meilisearch/meilisearch.go#L327
   This is a bug in https://github.com/apache/incubator-answer-plugins/pull/52
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "heubeck (via GitHub)" <gi...@apache.org>.
heubeck commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1881507521

   > > Will there be git tags / GH releases with the same version like answer itself, to allow a proper mapping?
   > 
   > Since all plugins are inside one repository, maybe it is not possible to mark the versions of all plugins with a single git tag.
   
   get the issue, nevertheless there needs to be a checkpoint for all of them for each answer version.
   
   maybe some tag name convention containing the plugin name and compatible answer version?
   that tag would need to point to always the latest compatible commit of a plugin, and `answer build` would need to respect it.
   
   🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #53:
URL: https://github.com/apache/incubator-answer-plugins/issues/53#issuecomment-1886885563

   > > Sounds good. We can fix what you said with the `search-meilisearch/v1.2.1` tag. For example, for now you can do it via `./answer build --with github.com/apache/incubator-answer-plugins/search-meilisearch@v1.2.1` command to pull this version of the plugin.
   > 
   > awesome, thx, @LinkinStars. Can you create similar tags for the other plugins as well?
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `answer build` with meilisearch plugin failing. [incubator-answer-plugins]

Posted by "heubeck (via GitHub)" <gi...@apache.org>.
heubeck closed issue #53: `answer build` with meilisearch plugin failing.
URL: https://github.com/apache/incubator-answer-plugins/issues/53


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org