You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2017/07/25 12:36:35 UTC

[GitHub] flink issue #4395: [FLINK-7263] Improve Pull Request template

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4395
  
    ## Discussion points so far
      - Is the text to verbose and should it be moved to the "how to contribute" section?
         - pro: less text in the template
         - con: "how to contribute" is frequently not read, text in the template only relevant for first time contributors (who we want to read it) and does not hurt repeated contributors (can simply skip/scroll over text)
    
      - Improve the sample texts (currently too much oriented at low level contributions)
    
      - Checkboxes versus *yes / no / don't know*
         - pro: check boxes are visually nicer
         - con: markdown checkboxes may be confusing to users, unchecked boxes are hard to distinguish between 'no' and 'did not know what to do'. Explicitly having *don't know* makes it clearer for contributors to not just skip that question when they are unsure. Seems more intuitive to allow for free text answers as well (if neither option works)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---