You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2016/03/15 00:33:36 UTC
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-84 guarantee null-terminate...
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/64
CLOWNFISH-84 guarantee null-terminated arg to strtod
Inside Str_To_F64 we use strtod, which requires a nul-terminated C
string argument. Now that Clownfish Strings consistently lack
nul-termination, we need to copy content into a nul-terminated buffer
and pass that to strtod.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish CLOWNFISH-84-nul-term-strtod
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 4dab61a5717135c4f60fc6d063e21870a453bb1f
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2016-03-14T23:05:23Z
Ensure nul-terminated arg to strtod.
Inside Str_To_F64 we use strtod, which requires a nul-terminated C
string argument. Now that Clownfish Strings consistently lack
nul-termination, we need to copy content into a nul-terminated buffer
and pass that to strtod.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-84 guarantee null-terminate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy-clownfish/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---