You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SayreBlades <gi...@git.apache.org> on 2014/08/13 17:37:35 UTC
[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
GitHub user SayreBlades opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13
Bad default configuration for IOS
This should not be a default ios setting:
<preference name="StatusBarBackgroundColor" value="#000000" />
It makes it impossible to unset the initial background color (for transparent backgrounds). Instead just have the default as no background color (which will effectively be transparent), and then allow users to override that with a desired color.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SayreBlades/cordova-plugin-statusbar patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 34f308e4a1713cc637c5c294a5c727848134bc27
Author: SayreBlades <sa...@gmail.com>
Date: 2014-08-13T15:37:11Z
Bad default configuration for IOS
This should not be a default ios setting:
<preference name="StatusBarBackgroundColor" value="#000000" />
It makes it impossible to unset the initial background color (for transparent backgrounds). Instead just have the default as no background color (which will effectively be transparent), and then allow users to override that with a desired color.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54662912
Filed https://issues.apache.org/jira/browse/CB-7486
@SayreBlades can you edit the title of the PR to have the prefix "CB-7486"? Thanks. This helps with some automation and linking with the JIRA issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: CB-7486: Remove StatusBarBa...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54719369
what preference are you setting?
@purplecabbage
risingj.com
On Fri, Sep 5, 2014 at 11:28 AM, Corentin H <no...@github.com>
wrote:
> The plugin is already installed but I cant' get the content to be white,
> otherwise I get a black opaque bar where I need a transparent one
> overlapping the WebView.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54663120>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54661974
All you need to do is install the status bar plugin, and set the preference you want in config.xml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
Posted by viki53 <gi...@git.apache.org>.
Github user viki53 commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54628779
Hi, any idea if and when this will be merged?
I need a transparent statusbar with light content on an app I'm building for a client.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-52085694
@SayreBlades please see:
http://wiki.apache.org/cordova/ContributorWorkflow (ICLA)
http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira; include bug id and meaningful description of change in commit message)
"Bad default configuration" isn't helpful, it should at least mention `StatusBarBackgroundColor`, probably as: "Remove `StatusBarBackgroundColor` default **preference**"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: CB-7486: Remove StatusBarBa...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-55671780
Patched: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=61024e5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: Bad default configuration f...
Posted by viki53 <gi...@git.apache.org>.
Github user viki53 commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54663120
The plugin is already installed but I cant' get the content to be white, otherwise I get a black opaque bar where I need a transparent one overlapping the WebView.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-statusbar pull request: CB-7486: Remove StatusBarBa...
Posted by SayreBlades <gi...@git.apache.org>.
Github user SayreBlades commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/13#issuecomment-54667095
@shazron done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---