You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/01/06 07:54:55 UTC

[GitHub] [unomi] sergehuber commented on a change in pull request #229: Bug fix in profile property condition and add getNestedProperty method

sergehuber commented on a change in pull request #229:
URL: https://github.com/apache/unomi/pull/229#discussion_r552420053



##########
File path: api/src/main/java/org/apache/unomi/api/Profile.java
##########
@@ -94,6 +95,30 @@ public Object getProperty(String name) {
         return properties.get(name);
     }
 
+    /**
+     * Retrieves the value of the nested property identified by the specified name.
+     *
+     * @param name the name of the property to be retrieved, splited in the nested properties with "."
+     * @return the value of the property identified by the specified name
+     */
+    public Object getNestedProperty(String name) {
+        if (!name.contains(".")) {

Review comment:
       I'm wondering if there is a way we could avoid this code duplication but I don't know where to put it unless we create some kind of static class in the API. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org