You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "PrinceGallywix (via GitHub)" <gi...@apache.org> on 2023/04/19 09:01:08 UTC

[GitHub] [superset] PrinceGallywix opened a new issue, #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

PrinceGallywix opened a new issue, #23735:
URL: https://github.com/apache/superset/issues/23735

After update to 2.1.0 from 2.0.1 we are unable to filter one line on chart with multiple dimensions via double clicking on it. (Does not depends on chart type: for example, Time-series Area chart and time-series bar chart had been tested).

It was very useful feature and all of our charts were depended on it (on version 2.0.1) - our users would simply double click on a single line to explore certain tendency rather then disabling every other line via navigation bar on top-right of the chart.

Are there any options to turn this feature back on?

#### How to reproduce the bug

1. Go to any chart (for example, 'Time-series Area chart') with multiple dimensions
2. Double click on a single row

### Expected results

Only chosen dimension left on a chart

### Actual results

Nothing happens, there are still multiple dimensions on a chart.

### Environment
- browser type and version: Google Chrome 109.0.5414.120 (also tested on Firefox 111.0.1)
- superset version: superset 2.1.0
- python version: python 3.8.12
- node.js version: node 10.24.0

### Checklist

- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] stasDomb commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "stasDomb (via GitHub)" <gi...@apache.org>.

stasDomb commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1550910177

   It's very convenient. When it will be fixed?
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PrinceGallywix commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "PrinceGallywix (via GitHub)" <gi...@apache.org>.

PrinceGallywix commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1553331116

   @rusackas thank you for reply! We are excited to try this  newfeature with 'All' and 'Invert' buttons!
   
   But I still don't get it...
   The double click feature is described in EchartsTimeseries module (the link in my previous comment), which one is NOT marked as deprecated and implemented in Echarts module. So, double click feature is in ECharts as well, isn't it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1553743337

   > @rusackas thank you for reply! We are excited to try this newfeature with 'All' and 'Invert' buttons!
   > 
   > But I still don't get it... The double click feature is described in EchartsTimeseries module (the link in my previous comment), which one is NOT marked as deprecated and implemented in Echarts module. So, double click feature is in ECharts as well, isn't it?
   > 
   > UPD: Here is the correct link to the function:
   > 
   > https://github.com/apache/superset/blob/357745f418d3eb42fececd6fd7d4a59337709a1d/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx#L72
   
   Yep, I see that in the code, and it looks like it ought to work, but I don't see it actually _doing_ anything. That probably ought to be debugged or removed, one way or the other.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jaimefr commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "jaimefr (via GitHub)" <gi...@apache.org>.

jaimefr commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1549218152

   Same issue too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina closed issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.

michael-s-molina closed issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0 
URL: https://github.com/apache/superset/issues/23735


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] xupeng commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "xupeng (via GitHub)" <gi...@apache.org>.

xupeng commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1541511878

   Same issue here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PrinceGallywix commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "PrinceGallywix (via GitHub)" <gi...@apache.org>.

PrinceGallywix commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1550920600

   Well, I'm trying to find out the reason this feature isn't working.
   
   I'm not a frontend developer and sorry for possible confusing, but here are some results:
   Comparing 2.1.0 with 2.0.1 in debug mode will show that EchartInstance reference won't be got anymore, I guess the problem in the reference handler:
   
   https://github.com/apache/superset/blob/357745f418d3eb42fececd6fd7d4a59337709a1d/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx#L59
   
   In 2.0.1 echartRef will be equal to ChartInstance object, but in 2.1.0 you will get _undefined_ 
   
   @villebro I see some of your activities in this module. Do you have any ideas how to fix this bug? Could you share your thoughts, please?
   
   As you can see, there are plenty of "DoubleClick feature" users :)  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1553294682

The current era ECharts (line, area, or otherwise) don't have a double-click feature. That sounds like what existed on the "legacy" (deprecated) line charts based on NVD3. Those still exist on 2.1.0, but will be migrated in 3.0.

What is NOT release in 2.1.0, but is available on `master` and will be available in 3.0 as well, are the ECharts equivalent, the All and Inverse buttons you see here.
<img width="744" alt="image" src="https://github.com/apache/superset/assets/812905/04bf4b6f-543c-4c8f-804a-502e94eb57f2">

ECharts does not and will not support double click actions like this (they're not discoverable to new users, arguably), so we're supporting the ECharts-native solution instead.

Hope this explains the situation... I'll close this for now, but if I'm misinterpreting the issue, let me know and we can re-open.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] PrinceGallywix commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "PrinceGallywix (via GitHub)" <gi...@apache.org>.

PrinceGallywix commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1554086163

@rusackas yep, it ought to work and it was OK in 2.0.1, but not in 2.1.0:

I've tryed to debug this feature, but then I got stuck. You can debug this in the next steps:
1. Open any time-series Echart (for example, open 'Time-series Bar Chart v2') with at least 2 dimensions,
2. Set a breakpoint on this line:
https://github.com/apache/superset/blob/357745f418d3eb42fececd6fd7d4a59337709a1d/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx#L75
(on the user side, the path is: _webpack://superset/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx_ )
3. Double click on any bar (or on the name of dimention in annotation layer)
4. Ok, now you are paused on a breakpoint
5. Check out the _echartInstance_ variable (which one is defined in the line above our debugging point). In 2.1.0 it is _undefined_. I guess this is the problem, the reference handler is broken somewhere, but I don't know where and how to fix it.

This is how it was looking like in 2.0.1:
![image](https://github.com/apache/superset/assets/77333963/307eb039-163a-4026-a534-5faf92a22dab)

In 2.1.0 we have _undefined_. This is because the _echartRef_ is null, which one is defined a little above.

If you have any ideas about this bug, please share :)

I guess we can re-open this issue, because it's not deprecated and it would be very helpful for us to use it until 3.0 release

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] michael-s-molina commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.

michael-s-molina commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1649849341

   This was fixed in https://github.com/apache/superset/pull/24477 and will be available in 3.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PrinceGallywix commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "PrinceGallywix (via GitHub)" <gi...@apache.org>.

PrinceGallywix commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1554100199

   Just for the record: this is where the feature is described and implemented previously:
   https://github.com/apache/superset/issues/16354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas closed issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas closed issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0 
URL: https://github.com/apache/superset/issues/23735


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] PrinceGallywix commented on issue #23735: Unable to filter dimension in chart by double click - after update from Supserset 2.0.1 to 2.1.0

Posted by "PrinceGallywix (via GitHub)" <gi...@apache.org>.

PrinceGallywix commented on issue #23735:
URL: https://github.com/apache/superset/issues/23735#issuecomment-1556701355

   @rusackas Can we re-open the issue, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org