You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/17 16:05:15 UTC
[GitHub] [maven-plugin-tools] cstamas opened a new pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
cstamas opened a new pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58
Those are not Maven Core components, they are merely in
wrong groupId. Extended ITs to use maven-jxr as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777858676
##########
File path: maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-good/pom.xml
##########
@@ -38,6 +38,12 @@ under the License.
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-jxr</artifactId>
+ <version>3.1.1</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
We have identified these two "cuckoo eggs" but am using only jxr in IT as maven-archiver pulls in a bunch of other deps, making IT run eons. I think for IT using jxr only is okay .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777684810
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
Review comment:
Can this ever change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777693659
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -185,8 +185,8 @@
private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
/**
- * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
- * Default value: {@code ["org.apache.maven:maven-archiver", "org.apache.maven:maven-jxr"]}.
+ * List of {@code groupID:artifactID} strings of artifact coordinates that are to be excluded from "expected
Review comment:
Well, the field above days `groupId`, not `groupID` and the former is the term we use everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r775010321
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -327,8 +327,11 @@ static String getDefaultGoalPrefix( MavenProject project )
for ( Artifact dependency : project.getArtifacts() )
{
+ // maven-archiver and maven-jxr are really in wrong groupId
if ( "org.apache.maven".equals( dependency.getGroupId() )
&& dependency.getArtifactId().startsWith( "maven-" )
+ && !dependency.getArtifactId().equals( "maven-archiver" )
+ && !dependency.getArtifactId().equals( "maven-jxr" )
Review comment:
Maybe put excludes names in some list to simplify expression ...
will be easier add next exclude
##########
File path: maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-bad/pom.xml
##########
@@ -38,6 +38,12 @@ under the License.
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-jxr</artifactId>
+ <version>3.1.1</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
There are no assertions for it ... so here is no need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777687378
##########
File path: maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-bad/pom.xml
##########
@@ -38,6 +38,12 @@ under the License.
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-jxr</artifactId>
+ <version>3.1.1</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
Wrong: removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777654757
##########
File path: maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-bad/pom.xml
##########
@@ -38,6 +38,12 @@ under the License.
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-jxr</artifactId>
+ <version>3.1.1</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
There are assertions to NOT have warnings, so to say, that these "excludes" are obeyed (maven-archiver and maven-jxr).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777682493
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
+
+ /**
+ * Flag controlling is "expected dependencies in provided scope" check to be performed or not. Default value:
+ * {@code true}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter( defaultValue = "true", property = "maven.plugin.checkExpectedProvidedScope" )
+ private boolean checkExpectedProvidedScope = true;
+
+ /**
+ * List of {@code groupId} strings of artifact coordinates that are expected to be in "provided" scope. Default
+ * value: {@code ["org.apache.maven"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
+
+ /**
+ * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
+ * Default value: {@code ["org.apache.maven:maven-archiver", "org.apache.maven:maven-jxr"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeExclusions = Arrays.asList(
Review comment:
Correct, hence they are excluded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] rmannibucau commented on pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#issuecomment-1000776513
Maven comes OOTB with:
````
apache-maven-3.8.4\lib\maven-artifact-3.8.4.jar
apache-maven-3.8.4\lib\maven-builder-support-3.8.4.jar
apache-maven-3.8.4\lib\maven-compat-3.8.4.jar
apache-maven-3.8.4\lib\maven-core-3.8.4.jar
apache-maven-3.8.4\lib\maven-embedder-3.8.4.jar
apache-maven-3.8.4\lib\maven-model-3.8.4.jar
apache-maven-3.8.4\lib\maven-model-builder-3.8.4.jar
apache-maven-3.8.4\lib\maven-plugin-api-3.8.4.jar
apache-maven-3.8.4\lib\maven-repository-metadata-3.8.4.jar
apache-maven-3.8.4\lib\maven-resolver-api-1.6.3.jar
apache-maven-3.8.4\lib\maven-resolver-connector-basic-1.6.3.jar
apache-maven-3.8.4\lib\maven-resolver-impl-1.6.3.jar
apache-maven-3.8.4\lib\maven-resolver-provider-3.8.4.jar
apache-maven-3.8.4\lib\maven-resolver-spi-1.6.3.jar
apache-maven-3.8.4\lib\maven-resolver-transport-wagon-1.6.3.jar
apache-maven-3.8.4\lib\maven-resolver-util-1.6.3.jar
apache-maven-3.8.4\lib\maven-settings-3.8.4.jar
apache-maven-3.8.4\lib\maven-settings-builder-3.8.4.jar
apache-maven-3.8.4\lib\maven-shared-utils-3.3.4.jar
apache-maven-3.8.4\lib\maven-slf4j-provider-3.8.4.jar
````
From there, maven-plugin-api and maven-model are public, part (part is important there) of maven-core is too and rest is fully undefined or private as of today - not 100% sure for artifact since it changed a bit but agree it used to leak so I assume it is okish to include it. This is only for built-in maven artifacts and not maven ecosystem so guess we can only whitelist the 2-3 dependencies and not include all and exclude a few in terms of impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] rmannibucau commented on pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#issuecomment-999733523
Can we really do it outside maven plugin api subgraph? Dont think so today :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas merged pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas merged pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777686532
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
Review comment:
IF this will never change then make is static final string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777693292
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
+
+ /**
+ * Flag controlling is "expected dependencies in provided scope" check to be performed or not. Default value:
+ * {@code true}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter( defaultValue = "true", property = "maven.plugin.checkExpectedProvidedScope" )
+ private boolean checkExpectedProvidedScope = true;
+
+ /**
+ * List of {@code groupId} strings of artifact coordinates that are expected to be in "provided" scope. Default
+ * value: {@code ["org.apache.maven"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
+
+ /**
+ * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777693632
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
Review comment:
in any case, that change is unrelated to this PR... Again, I just fixed a warning, but I can undo this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777677168
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -327,8 +327,11 @@ static String getDefaultGoalPrefix( MavenProject project )
for ( Artifact dependency : project.getArtifacts() )
{
+ // maven-archiver and maven-jxr are really in wrong groupId
if ( "org.apache.maven".equals( dependency.getGroupId() )
&& dependency.getArtifactId().startsWith( "maven-" )
+ && !dependency.getArtifactId().equals( "maven-archiver" )
+ && !dependency.getArtifactId().equals( "maven-jxr" )
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777684599
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
+
+ /**
+ * Flag controlling is "expected dependencies in provided scope" check to be performed or not. Default value:
+ * {@code true}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter( defaultValue = "true", property = "maven.plugin.checkExpectedProvidedScope" )
+ private boolean checkExpectedProvidedScope = true;
+
+ /**
+ * List of {@code groupId} strings of artifact coordinates that are expected to be in "provided" scope. Default
+ * value: {@code ["org.apache.maven"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
+
+ /**
+ * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
+ * Default value: {@code ["org.apache.maven:maven-archiver", "org.apache.maven:maven-jxr"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeExclusions = Arrays.asList(
Review comment:
OK, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777685044
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
Review comment:
unsure, I just got rid of warning (one param to Arrays.asList).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777681736
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
+
+ /**
+ * Flag controlling is "expected dependencies in provided scope" check to be performed or not. Default value:
+ * {@code true}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter( defaultValue = "true", property = "maven.plugin.checkExpectedProvidedScope" )
+ private boolean checkExpectedProvidedScope = true;
+
+ /**
+ * List of {@code groupId} strings of artifact coordinates that are expected to be in "provided" scope. Default
+ * value: {@code ["org.apache.maven"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
+
+ /**
+ * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
+ * Default value: {@code ["org.apache.maven:maven-archiver", "org.apache.maven:maven-jxr"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeExclusions = Arrays.asList(
Review comment:
But those aren't expected to be in provided scope, are they? They are just int he wrong group id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] cstamas commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777709743
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -185,8 +185,8 @@
private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
/**
- * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
- * Default value: {@code ["org.apache.maven:maven-archiver", "org.apache.maven:maven-jxr"]}.
+ * List of {@code groupID:artifactID} strings of artifact coordinates that are to be excluded from "expected
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] kwin commented on pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#issuecomment-1000757025
@rmannibucau Which other false positives do you foresee? I am actually thankful for the warnings for "maven-artifact" and "maven-model" (those are API IMHO since forever)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] rmannibucau commented on pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#issuecomment-999870917
@michael-o except maven-plugin-api which is intentionally exposed rest of maven sub-artifacts are random and either internals or public API so none can be assumed being provided so this sounds like a lot of false positive to me. What about not warning for all but the plugin api and maybe maven-core?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#issuecomment-999835738
> Can we really do it outside maven plugin api subgraph? Dont think so today :(
WDYM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777685206
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
+
+ /**
+ * Flag controlling is "expected dependencies in provided scope" check to be performed or not. Default value:
+ * {@code true}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter( defaultValue = "true", property = "maven.plugin.checkExpectedProvidedScope" )
+ private boolean checkExpectedProvidedScope = true;
+
+ /**
+ * List of {@code groupId} strings of artifact coordinates that are expected to be in "provided" scope. Default
+ * value: {@code ["org.apache.maven"]}.
+ *
+ * @since 3.6.3
+ */
+ @Parameter
+ private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
+
+ /**
+ * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
Review comment:
You should write out `G:A`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777714756
##########
File path: maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-good/pom.xml
##########
@@ -38,6 +38,12 @@ under the License.
</properties>
<dependencies>
+ <dependency>
+ <groupId>org.apache.maven</groupId>
+ <artifactId>maven-jxr</artifactId>
+ <version>3.1.1</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
Should be also added `org.apache.maven:maven-archiver` unless is present on dependency tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r777694832
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -163,7 +164,36 @@
* @since 3.3
*/
@Parameter
- protected List<String> packagingTypes = Arrays.asList( "maven-plugin" );
+ protected List<String> packagingTypes = Collections.singletonList( "maven-plugin" );
Review comment:
Yes, you are right. Let's keep your change. I have just noticed this and it felt awkward.
##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -185,8 +185,8 @@
private List<String> expectedProvidedScopeGroupIds = Collections.singletonList( "org.apache.maven" );
/**
- * List of {@code G:A} strings of artifact coordinates that are to be excluded from "expected provided scope" check.
- * Default value: {@code ["org.apache.maven:maven-archiver", "org.apache.maven:maven-jxr"]}.
+ * List of {@code groupID:artifactID} strings of artifact coordinates that are to be excluded from "expected
Review comment:
Well, the field above says `groupId`, not `groupID` and the former is the term we use everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org