[jira] [Commented] (MAPREDUCE-1194) mapred.reduce.slowstart.completed.maps allows values more than 1.0 and less than 0.0

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463318#comment-13463318 ] 

Hadoop QA commented on MAPREDUCE-1194:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12546601/MAPREDUCE-1194.rev1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2879//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2879//console

This message is automatically generated.
                
> mapred.reduce.slowstart.completed.maps allows values more than 1.0 and less than 0.0
> ------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1194
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1194
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Maxim Zizin
>            Priority: Minor
>         Attachments: MAPREDUCE-1194.rev1.patch
>
>
> When run with value less than 0.0 (e.g. -1.0) works similar to 0.0, but when value is more than 1.0 (e.g. 50.0) reducers don't start at all. Is there a reason why such values are allowed? I understand that this is clear from the description that parameter is fraction but some people may forget and confuse it with percents and as result have problems. Why not throw an error in this case?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira