You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "vcrfxia (via GitHub)" <gi...@apache.org> on 2023/04/13 19:19:22 UTC

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

vcrfxia commented on code in PR #13554:
URL: https://github.com/apache/kafka/pull/13554#discussion_r1165935761


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java:
##########
@@ -84,22 +86,37 @@
         extends MeteredKeyValueStore<K, ValueAndTimestamp<V>> {
 
         private final VersionedBytesStore inner;
+        private final Serde<V> rawValueSerde;

Review Comment:
   `valueSerde` is already defined in the base class, and I couldn't come up with a better name 😆 Suggestions welcome!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org