You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "RaigorJiang (via GitHub)" <gi...@apache.org> on 2023/02/03 06:26:10 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue, #23955: Optimize the inheritance structure of RALStatement

RaigorJiang opened a new issue, #23955:
URL: https://github.com/apache/shardingsphere/issues/23955

   Now, the inheritance structure of RALStatement is a bit less clear compared to RDLStatement and RQLStatement.
   
   ### RDLStatement
   <img width="567" alt="image" src="https://user-images.githubusercontent.com/5668787/216525569-bad545fd-2ac1-4b69-962f-07acae62f745.png">
   
   ### RALStatement
   <img width="584" alt="image" src="https://user-images.githubusercontent.com/5668787/216525679-b25b0a60-0d24-4365-8dbc-3e6a5ee363f4.png">
   
   As shown in the figure, `QueryableRALStatement`, `UpdatableRALStatement` and `ScalingRALStatement`, they should not be classified at the same level.
   And `HintRALStatement` is also special (will be removed in #23953).
   
   I plan to classify `RALStatement` as follows to optimize their inheritance relationship:
   
   <img width="967" alt="image" src="https://user-images.githubusercontent.com/5668787/216527523-032c3010-1d54-4566-ae07-c71968455b5e.png">
   
   Please let me know if you have any suggestions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #23955: Optimize the inheritance structure of RALStatement

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang closed issue #23955: Optimize the inheritance structure of RALStatement 
URL: https://github.com/apache/shardingsphere/issues/23955


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on issue #23955: Optimize the inheritance structure of RALStatement

Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on issue #23955:
URL: https://github.com/apache/shardingsphere/issues/23955#issuecomment-1420040231

   Hi @RaigorJiang , can i join.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #23955: Optimize the inheritance structure of RALStatement

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on issue #23955:
URL: https://github.com/apache/shardingsphere/issues/23955#issuecomment-1420081339

   @yx9o Yes, you are welcome, feel free to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org