[GitHub] [spark] zsxwing commented on a change in pull request #30336: [SPARK-33287][SS][UI]Expose state custom metrics information on SS UI

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #30336:
URL: https://github.com/apache/spark/pull/30336#discussion_r527288900



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -178,14 +178,14 @@ object StateStoreMetrics {
 trait StateStoreCustomMetric {
   def name: String
   def desc: String
-  def unit: String
+  def unit: String = ""
 }
 
-case class StateStoreCustomSumMetric(name: String, desc: String, unit: String)
+case class StateStoreCustomSumMetric(name: String, desc: String, override val unit: String)

Review comment:
       Adding a parameter to a case class is neither source compatible nor binary compatible. I think it's okay to ignore unit on the graph since the metric name has this information. We can re-consider to add unit when we hear the voice from the user.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org