Re: [PR] Delete user-project mappings on project deletion [cloudstack]

["weizhouapache (via GitHub)" <gi...@apache.org>]

weizhouapache commented on PR #13456:
URL: https://github.com/apache/cloudstack/pull/13456#issuecomment-5213883777

   > > I also checked the other uses, for example deleting the `user1` of the project and no regressions occurred.
   > 
   > @Tonitzpp thanks for the checking the case. however, the method `ProjectAccountSearch` is being used in many places. It would be better to check more cases which might be broken by the change:
   > 
   > ```
   > -        ProjectAccountSearch.and("userId", ProjectAccountSearch.entity().getUserId(), Op.NULL);
   > ```
   > 
   > an alternative way is, create a new method instead of changing the existing method
   
   @Tonitzpp 
   could you please consider it ?
   
   cc @bernardodemarco 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org