You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/10 03:48:56 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7072: net/usrsock: Remove the unnecessary extra space
xiaoxiang781216 opened a new pull request, #7072:
URL: https://github.com/apache/incubator-nuttx/pull/7072
## Summary
## Impact
No, code refactor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7072: net/usrsock: Code refactor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7072:
URL: https://github.com/apache/incubator-nuttx/pull/7072#discussion_r967655785
##########
drivers/usrsock/usrsock_dev.c:
##########
@@ -58,13 +58,13 @@
struct usrsockdev_s
{
- sem_t devsem; /* Lock for device node */
- uint8_t ocount; /* The number of times the device has been opened */
+ sem_t devsem; /* Lock for device node */
+ uint8_t ocount; /* The number of times the device has been opened */
struct
{
- FAR const struct iovec *iov; /* Pending request buffers */
- int iovcnt; /* Number of request buffers */
- size_t pos; /* Reader position on request buffer */
+ FAR const struct iovec *iov; /* Pending request buffers */
+ int iovcnt; /* Number of request buffers */
+ size_t pos; /* Reader position on request buffer */
} req;
struct pollfd *pollfds[CONFIG_NET_USRSOCKDEV_NPOLLWAITERS];
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7072: net/usrsock: Code refactor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7072:
URL: https://github.com/apache/incubator-nuttx/pull/7072#discussion_r967622647
##########
drivers/usrsock/usrsock_dev.c:
##########
@@ -58,13 +58,13 @@
struct usrsockdev_s
{
- sem_t devsem; /* Lock for device node */
- uint8_t ocount; /* The number of times the device has been opened */
+ sem_t devsem; /* Lock for device node */
+ uint8_t ocount; /* The number of times the device has been opened */
struct
{
- FAR const struct iovec *iov; /* Pending request buffers */
- int iovcnt; /* Number of request buffers */
- size_t pos; /* Reader position on request buffer */
+ FAR const struct iovec *iov; /* Pending request buffers */
+ int iovcnt; /* Number of request buffers */
+ size_t pos; /* Reader position on request buffer */
} req;
struct pollfd *pollfds[CONFIG_NET_USRSOCKDEV_NPOLLWAITERS];
Review Comment:
```suggestion
FAR struct pollfd *pollfds[CONFIG_NET_USRSOCKDEV_NPOLLWAITERS];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7072: net/usrsock: Code refactor
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #7072:
URL: https://github.com/apache/incubator-nuttx/pull/7072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org